search

julia-cp / pe

0 stars 0 forks source link

Editing a person can create a duplicate of another person #2

Open julia-cp opened 4 months ago

julia-cp commented 4 months ago

From the user guide, can see that you should be unable to edit a person to become a duplicate of another person, and a person is considered a duplicate if two persons share the same name and the same phone number/email. Screenshot 2024-04-19 at 4.20.04 PM.png

Screenshot 2024-04-19 at 4.20.44 PM.png

Steps to reproduce:

  1. Open the original file
  2. type edit 1 n/Bernice Yu
  3. type edit 1 p/99272758

Expected: error message

Actual: able to edit Screenshot 2024-04-19 at 4.21.45 PM.png

soc-se-bot commented 4 months ago

Team's Response

This may be a misunderstanding between the user and UG and we have taken note of that.

However, we have taken this into consideration and have actually included examples in the field constraint section in the UG. (see below)

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: In the user guide it is stated that you should be unable to edit a person to become a duplicate of another person. Also in the user guide: Screenshot 2024-04-23 at 7.13.56 PM.png Screenshot 2024-04-23 at 7.14.11 PM.png

This is the same case as the screenshot provided. Both index 1 and 2 have the same name (Bernice Yu) and same phone number (99272758). As I mentioned, this is a result of:

  1. Open the original file
  2. type edit 1 n/Bernice Yu
  3. type edit 1 p/99272758

Which means I am able to edit a person to become a duplicate of another person. This contradicts the user guide.

## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** This is a Functionality Bug because the behaviour differs from the User Guide.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** ![Screenshot 2024-04-23 at 7.22.13 PM.png](https://raw.githubusercontent.com/julia-cp/pe/main/files/a7e21a7c-40c6-4943-97fa-988729b26c4a.png) This issue will affect users who use the edit feature and expect the duplicate detection to be working. Considering the group included this in their feature, I will assume that this is something that they expected to happen. As they should, it is possible for the user to add a contact, and then later on forget and add the contact again but with some typos. When they edit them to fix the typos, the duplicate detection will fail and they will have the same person in the addressbook. Therefore, this flaw causes occasional inconvenience to some users and should be classified as Medium severity.