search

julia-mpsge / MPSGE_MP.jl

MIT License
1 stars 0 forks source link

Updating default numeraire #22

Closed mitchphillipson closed 2 months ago

mitchphillipson commented 4 months ago

Related to issue #20

mitchphillipson commented 4 months ago

Currently failing tests because setting the default numeraire requires the value of a auxiliary variable before the model is solved.

Could be an issue.

mitchphillipson commented 3 months ago

Here is the issue. We can have auxiliary variables as part of expressions in quantities. The way I'm dealing with MPSGEVariables in expressions is to always defer to the base JuMP variable, so if $X$ is an auxiliary variable then $4X$ becomes `4get_variable(X)` as an expression.

We need quantities of these objects BEFORE the model is solved in order to determine what the numeraire is. And this is the issue.

EliLazarus commented 2 months ago

Not related specifically to this PR, but can we integrate the unit tests, using TestItemRunner and @testitem, integrating them into VSCode and github? I could do a quick branch and PR. It's a hurdle setting that up each time to look at the PR.

mitchphillipson commented 2 months ago

Sure

On Mon, Jun 17, 2024, 7:24 PM EliLazarus @.***> wrote:

Not related specifically to this PR, but can we integrate the unit tests, using TestItemRunner and @testitem, integrating them into VSCode and github? I could do a quick branch and PR. It's a hurdle setting that up each time to look at the PR.

— Reply to this email directly, view it on GitHub https://github.com/julia-mpsge/MPSGE_MP.jl/pull/22#issuecomment-2174676815, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEVAPXMFK5PSU2HADGOJFNDZH5437AVCNFSM6AAAAABHCKCBI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZUGY3TMOBRGU . You are receiving this because you authored the thread.Message ID: @.***>