search

julia-vscode / DocumentFormat.jl

Auto-formatter for Julia
Other
62 stars 18 forks source link

don't indent testset blocks #100

Closed ZacLN closed 2 years ago

pfitzseb commented 4 years ago

What's wrong with indenting @testsets?

ZacLN commented 4 years ago

I thought the feeling was they shouldn't be indented a they're likely to be highly nested?

pfitzseb commented 4 years ago

Fair enough. Base does indent testsets though. Anyways, I don't feel particularly strongly about this.

davidanthoff commented 4 years ago

Fair enough. Base does indent testsets though.

Oh, interesting, I wasn't aware of that. That seems like a pretty strong reason to actually keep the indenting?

ZacLN commented 4 years ago

Can't say I feel particularly strongly about this so happy to be guided by others

davidanthoff commented 4 years ago

I think generally following Julia base is a good idea for these things. I also don't feel strongly one way or the other, so just following the lead of the core seems an easy way to decide this.

We could leave this PR open and eventually add an option to configure this?