fix constructor on 32bit OSs

julia-vscode / DocumentFormat.jl

Auto-formatter for Julia

Other

62 stars 18 forks source link

fix constructor on 32bit OSs #132

Closed pfitzseb closed 3 years ago

pfitzseb commented 3 years ago

Hopefully fixes https://github.com/julia-vscode/crashreporting-issues/issues/30. Couldn't repro the bug on a 32bit install of Julia with this patch.

For every PR, please check the following:

[x] End-user documentation check. If this PR requires end-user documentation in the Julia VS Code extension docs, please add that at https://github.com/julia-vscode/docs.
[x] Changelog mention. If this PR should be mentioned in the CHANGELOG for the Julia VS Code extension, please open a PR against https://github.com/julia-vscode/julia-vscode/blob/master/CHANGELOG.md with those changes.

pfitzseb commented 3 years ago

So I think the issue is that JSON will always deserialize an integer to an Int64 instead of a platform-specific Int. Seems easiest to just allow arbitrary Integers here instead of only Ints so we don't need to rewrite our tests to run on x86.

davidanthoff commented 3 years ago

Ah, yes, I remember that JSON issue from other contexts!