search

julia-vscode / DocumentFormat.jl

Auto-formatter for Julia
Other
62 stars 18 forks source link

Add constructor for FormatOptions that coalesces nothing #94

Closed non-Jedi closed 4 years ago

non-Jedi commented 4 years ago

Any field of FormatOptions with nothing will be set to default value.

This is the part of fixing https://github.com/julia-vscode/LanguageServer.jl/issues/624

non-Jedi commented 4 years ago

Double-checked this while doing the lint one, and currently lineends is unspecified by the vscode config so is set to false (only one not set to true by default). Should that one be disabled for best default UX?

non-Jedi commented 4 years ago

Broken tests appear unrelated?

ZacLN commented 4 years ago

Yes I think so

davidanthoff commented 4 years ago

@non-Jedi could you merge master in? I think I just fixed the tests there. I just did, too easy with this one button here :)