Omni completion broken with LanguageClient-neovim

[IngoMeyer441]

Hey, thanks for this project. I am new to Julia and Lanuage Servers and I am searching for a good autocompletion for Julia. So I tried this Language Server with LanguageClient-neovim but I don't get it running.

My testing setup:

• Debian unstable in a Docker container to have a clean system
• Latest Neovim (dc536295)

• A minimal .vimrc managed by dein.vim:

  set nocompatible
  
  set runtimepath+=/root/.vim/dein/repos/github.com/Shougo/dein.vim
  if dein#load_state('/root/.vim/dein')
  call dein#begin('/root/.vim/dein')
  call dein#add('Shougo/dein.vim')
  call dein#add('JuliaEditorSupport/julia-vim')
  call dein#add('autozimu/LanguageClient-neovim', {
                          \ 'rev': 'next',
                          \ 'build': 'bash install.sh'
                          \ })
  call dein#end()
  call dein#save_state()
  endif
  
  filetype plugin indent on
  syntax enable
  set background=dark
  
  let g:default_julia_version = '0.6'
  
  " language server
  let g:LanguageClient_autoStart = 1
  let g:LanguageClient_serverCommands = {
  \   'julia': ['julia', '--startup-file=no', '--history-file=no', '-e', '
  \       using LanguageServer;
  \       server = LanguageServer.LanguageServerInstance(STDIN, STDOUT, false);
  \       server.runlinter = true;
  \       run(server);
  \   '],
  \ }

• Julia version 0.6.2
• The language server itself is installed via

  Pkg.clone("https://github.com/JuliaEditorSupport/LanguageServer.jl")

When I open an empty Julia file, type prin and invoke Omni completion by typing C-x C-o neovim freezes completely. After quiting the editor I can find the following log files in /tmp:

• LanguageClient.log:

  2018-02-08T14:34:22.201214959+00:00 WARN languageclient::utils - Unknown project type. 
  Fallback to use dir as project root: Ok("/root")
  2018-02-08T14:34:24.411330748+00:00 WARN languageclient::languageclient - Not opened yet. 
  Switching to didOpen.
  2018-02-08T14:34:32.386385524+00:00 WARN languageclient::languageclient - Unknown 
  notification: "window/setStatusReady"
  2018-02-08T14:34:36.583330602+00:00 ERROR languageclient::languageclient - RPC-julia thread 
  error: failed to fill whole buffer
  2018-02-08T14:34:48.056724434+00:00 ERROR languageclient::languageclient - Error handling 
  message. Message: {"method": "languageClient/handleTextChanged", "jsonrpc": "2.0", "params": 
  {"languageId": "julia", "buftype": "", "text": ["prin"], "filename": "/root/test.jl"}}. Error: Error { repr: Os { 
  code: 32, message: "Broken pipe" } }

• LanguageServer.log:

  ERROR: MethodError: Cannot `convert` an object of type Void to an object of type 
  LanguageServer.Range
  This may have arisen from a call to the constructor LanguageServer.Range(...),
  since type constructors fall back to convert methods.
  Stacktrace:
  [1] LanguageServer.Range(::Void) at ./sysimg.jl:77
  [2] LanguageServer.TextDocumentContentChangeEvent(::Dict{String,Any}) at 
  /root/.julia/v0.6/LanguageServer/src/protocol/document.jl:85
  [3] macro expansion at ./broadcast.jl:155 [inlined]
  [4] macro expansion at ./simdloop.jl:73 [inlined]
  [5] macro expansion at ./broadcast.jl:149 [inlined]
  [6] _broadcast!(::Type{LanguageServer.TextDocumentContentChangeEvent}, 
  ::Array{LanguageServer.TextDocumentContentChangeEvent,1}, ::Tuple{Tuple{Bool}}, 
  ::Tuple{Tuple{Int64}}, ::Array{Any,1}, ::Tuple{}, ::Type{Val{0}}, ::CartesianRange{CartesianIndex{1}}) at 
  ./broadcast.jl:141
  [7] broadcast_t(::Type{T} where T, ::Type{T} where T, ::Tuple{Base.OneTo{Int64}}, 
  ::CartesianRange{CartesianIndex{1}}, ::Array{Any,1}) at ./broadcast.jl:270
  [8] broadcast_c at ./broadcast.jl:316 [inlined]
  [9] broadcast(::Type{T} where T, ::Array{Any,1}) at ./broadcast.jl:455
  [10] LanguageServer.DidChangeTextDocumentParams(::Dict{String,Any}) at 
  /root/.julia/v0.6/LanguageServer/src/protocol/document.jl:95
  [11] parse_params(::Type{Val{Symbol("textDocument/didChange")}}, ::Dict{String,Any}) at 
  /root/.julia/v0.6/LanguageServer/src/requests/textDocument.jl:40
  [12] parse(::Type{LanguageServer.JSONRPC.Request}, ::Dict{String,Any}) at 
  /root/.julia/v0.6/LanguageServer/src/jsonrpc.jl:38
  [13] run(::LanguageServer.LanguageServerInstance) at 
  /root/.julia/v0.6/LanguageServer/src/languageserverinstance.jl:37

[IngoMeyer441]

I have written a small Dockerfile to reproduce my testing container:

FROM debian:unstable
LABEL maintainer="Ingo Heimbach <i.heimbach@fz-juelich.de>"

RUN apt-get update && \
    apt-get install --no-install-recommends -y automake \
                                               build-essential \
                                               ca-certificates \
                                               cmake \
                                               curl \
                                               gettext \
                                               git \
                                               libtool-bin \
                                               pkg-config \
                                               unzip && \
    rm -rf /var/lib/apt/lists/*

WORKDIR /tmp

RUN curl -O -L https://julialang-s3.julialang.org/bin/linux/x64/0.6/julia-0.6.2-linux-x86_64.tar.gz && \
    tar -xvf julia-0.6.2-linux-x86_64.tar.gz && \
    rm -f julia-0.6.2-linux-x86_64.tar.gz && \
    cd julia-*/ && \
    cp -r bin etc include lib share /usr/local/ && \
    cd .. && \
    rm -rf julia-*

RUN git clone https://github.com/neovim/neovim.git && \
    cd neovim && \
    make CMAKE_BUILD_TYPE=Release && \
    make install && \
    cd .. && \
    rm -rf neovim

RUN julia -e 'Pkg.clone("https://github.com/JuliaEditorSupport/LanguageServer.jl")'

RUN curl https://raw.githubusercontent.com/Shougo/dein.vim/master/bin/installer.sh > installer.sh && \
    bash installer.sh ~/.vim/dein && \
    rm -f installer.sh

RUN mkdir -p "${HOME}/.config/nvim" && \
    echo 'set runtimepath^=~/.vim runtimepath+=~/.vim/after\n\
let &packpath = &runtimepath\n\
source ~/.vimrc' \
> "${HOME}/.config/nvim/init.vim" && \
    echo "set nocompatible\n\
\n\
set runtimepath+=/root/.vim/dein/repos/github.com/Shougo/dein.vim\n\
if dein#load_state('/root/.vim/dein')\n\
  call dein#begin('/root/.vim/dein')\n\
  call dein#add('Shougo/dein.vim')\n\
  call dein#add('JuliaEditorSupport/julia-vim')\n\
  call dein#add('autozimu/LanguageClient-neovim', {\n\
                          \ 'rev': 'next',\n\
                          \ 'build': 'bash install.sh'\n\
                          \ })\n\
  call dein#end()\n\
  call dein#save_state()\n\
endif\n\
\n\
filetype plugin indent on\n\
syntax enable\n\
set background=dark\n\
\n\
let g:default_julia_version = '0.6'\n\
\n\
\" language server\n\
let g:LanguageClient_autoStart = 1\n\
let g:LanguageClient_serverCommands = {\n\
\   'julia': ['julia', '--startup-file=no', '--history-file=no', '-e', '\n\
\       using LanguageServer;\n\
\       server = LanguageServer.LanguageServerInstance(STDIN, STDOUT, false);\n\
\       server.runlinter = true;\n\
\       run(server);\n\
\   '],\n\
\ }\n" \
> /root/.vimrc

RUN echo ":call dein#install()\n" > ./vim_install_plugins && \
    echo '#!/bin/bash\nnvim -s /tmp/vim_install_plugins\nexec "$@"' > /tmp/entrypoint.sh && \
    chmod +x /tmp/entrypoint.sh

WORKDIR /root

RUN echo "prin" > test.jl

ENTRYPOINT ["/tmp/entrypoint.sh"]
CMD ["/bin/bash"]

After saving the file to Dockerfile you can run

docker build -t language-server-issue:latest -f Dockerfile .
docker run -it language-server-issue:latest

Neovim is opened automatically and installs julia-vim and LanguageClient-neovim. When the installation is complete, you can close Neovim and open my test file with:

nvim test.jl

I hope that makes finding the problem a bit easier :smiley:.

[davidanthoff]

I don’t remember who worked on the neovim options, I’m afraid I can’t help with this one because I’m not a neovim user...

[IngoMeyer441]

I have also tested LanguageClient-neovim with vim8 and Omni completion hangs for original vim as well...

[IngoMeyer441]

Here is the Dockerfile replacing Neovim with Vim 8:

FROM debian:unstable
LABEL maintainer="Ingo Heimbach <i.heimbach@fz-juelich.de>"

RUN apt-get update && \
    apt-get install --no-install-recommends -y ca-certificates \
                                               curl \
                                               git \
                                               vim-athena && \
    rm -rf /var/lib/apt/lists/*

WORKDIR /tmp

RUN curl -O -L https://julialang-s3.julialang.org/bin/linux/x64/0.6/julia-0.6.2-linux-x86_64.tar.gz && \
    tar -xvf julia-0.6.2-linux-x86_64.tar.gz && \
    rm -f julia-0.6.2-linux-x86_64.tar.gz && \
    cd julia-*/ && \
    cp -r bin etc include lib share /usr/local/ && \
    cd .. && \
    rm -rf julia-*

RUN julia -e 'Pkg.clone("https://github.com/JuliaEditorSupport/LanguageServer.jl")'

RUN curl https://raw.githubusercontent.com/Shougo/dein.vim/master/bin/installer.sh > installer.sh && \
    bash installer.sh ~/.vim/dein && \
    rm -f installer.sh

RUN echo "set nocompatible\n\
\n\
set runtimepath+=/root/.vim/dein/repos/github.com/Shougo/dein.vim\n\
if dein#load_state('/root/.vim/dein')\n\
  call dein#begin('/root/.vim/dein')\n\
  call dein#add('Shougo/dein.vim')\n\
  call dein#add('JuliaEditorSupport/julia-vim')\n\
  call dein#add('autozimu/LanguageClient-neovim', {\n\
                          \ 'rev': 'next',\n\
                          \ 'build': 'bash install.sh'\n\
                          \ })\n\
  call dein#end()\n\
  call dein#save_state()\n\
endif\n\
\n\
filetype plugin indent on\n\
syntax enable\n\
set background=dark\n\
\n\
let g:default_julia_version = '0.6'\n\
\n\
\" language server\n\
let g:LanguageClient_autoStart = 1\n\
let g:LanguageClient_serverCommands = {\n\
\   'julia': ['julia', '--startup-file=no', '--history-file=no', '-e', '\n\
\       using LanguageServer;\n\
\       server = LanguageServer.LanguageServerInstance(STDIN, STDOUT, false);\n\
\       server.runlinter = true;\n\
\       run(server);\n\
\   '],\n\
\ }\n" \
> /root/.vimrc

RUN echo ":call dein#install()\n" > ./vim_install_plugins && \
    echo '#!/bin/bash\nvim -s /tmp/vim_install_plugins\nexec "$@"' > /tmp/entrypoint.sh && \
    chmod +x /tmp/entrypoint.sh

WORKDIR /root

RUN echo "prin" > test.jl

ENTRYPOINT ["/tmp/entrypoint.sh"]
CMD ["/bin/bash"]

[davidanthoff]

So I'm putting this on the backlog for now because I'm just not familiar with vim or neovim. I think the best hope here is that we can entice the person that sorted out the neovim support in the first place to take a look.

[joshbode]

Hmm - well, that looks like my config :)

This is my current config using ncm2 and vim-plug:

" plugins
call g:plug#begin()
  Plug 'autozimu/LanguageClient-neovim', {'branch': 'next', 'do': './install.sh'}
  Plug 'ncm2/ncm2' | Plug 'roxma/nvim-yarp'
  Plug 'sheerun/vim-polyglot'
call g:plug#end()

" language server
let g:LanguageClient_serverCommands = {
\   'julia': ['julia', '--startup-file=no', '--history-file=no', '-e', '
\       import LanguageServer;
\       server = LanguageServer.LanguageServerInstance(stdin, stdout, false);
\       server.runlinter = true;
\       run(server);
\   '],
\ }

nnoremap <silent> K :call LanguageClient_textDocument_hover()<CR>
nnoremap <silent> gd :call LanguageClient_textDocument_definition()<CR>
nnoremap <silent> <F2> :call LanguageClient_textDocument_rename()<CR>

Note: To get it working on master I needed to make a few changes (see #274). I still don't have omnicomplete working for modules other than Base and Core but it is a start :)

[joshbode]

274 is merged now :)

[rebelot]

@joshbode does this work with Julia 1.0? I am using the same configuration but I can't make it to work.

I get this error message: data did not match any variant of untagged enum CompletionResponse

[joshbode]

Yes to Julia 1.0.

Hmm - try adding (edited above!):

  Plug 'sheerun/vim-polyglot'

I didn't get the same error as you, but it was required to get the minimal config working when I just tested it now.

Without it, Julia files were being interpreted as Lisp

[rebelot]

@joshbode I do not use vim-polyglot, but I have JuliaEditorSupport/julia-vim in my Plug list, which is basically what vim-polyglot is providing. I am using the latest updates of ncm2 and language-client, the Julia language server is installed via pkg mode cloning this repo. I am confused!

[davidanthoff]

Is this still an issue, or can we close this?