search

julia-vscode / SymbolServer.jl

Other
23 stars 31 forks source link

comment out disabled code blocks #165

Closed ZacLN closed 4 years ago

ZacLN commented 4 years ago

Core.Compiler.Params doesn't exist on Julia 1.6

pfitzseb commented 4 years ago

@aviatesk has a fix for that at https://github.com/JunoLab/Atom.jl/pull/335 :)

aviatesk commented 4 years ago

is this used somewhere ? I think I can fix that though.

pfitzseb commented 4 years ago

Well, https://github.com/julia-vscode/SymbolServer.jl/pull/165/files#diff-6a3b27e5bfe405fa75cb4196464e0adcL114 means the code wasn't used anyways.

ZacLN commented 4 years ago

It's in the title!

davidanthoff commented 4 years ago

:) True, but who reads ;)