Closed pfitzseb closed 4 years ago
Side note - could we all try to keep formatting changes to separate PRs?
Yeah, sorry about that -- seems like VSCode is autoformatting files on save :)
We turn on auto-formatting on save here, but we may want to make that TS-specific.
Eh, I like that behaviour. It's just that the kwarg option is different between what I have locally set and this codebase. So either we fix that in .vscode
or reformat our Julia code.
The newly added
all_names
has a few advantages oversplit_module_names
:julia> @time SymbolServer.split_module_names(JSON, allns); 0.015986 seconds (19.93 k allocations: 1.255 MiB)
julia> :parse in all_names(JSON) true
julia> a, b = SymbolServer.split_module_names(JSON, allns);
julia> :parse in a || :parse in b false