remove limit on type names

julia-vscode / SymbolServer.jl

Other

22 stars 31 forks source link

remove limit on type names #219

Open ZacLN opened 3 years ago

ZacLN commented 3 years ago

Store full names of DataTypes. This was disable previously as it slows caching but this should be reversed if we're moving to the cloud approach.

For every PR, please check the following:

[x] End-user documentation check. If this PR requires end-user documentation in the Julia VS Code extension docs, please add that at https://github.com/julia-vscode/docs.
[x] Changelog mention. If this PR should be mentioned in the CHANGELOG for the Julia VS Code extension, please open a PR against https://github.com/julia-vscode/julia-vscode/blob/master/CHANGELOG.md with those changes.

davidanthoff commented 3 years ago

Needs a merge conflict resolution.

Does this affect our cache store? If so, we need to cycle this in with a cache store version update, right? So v1.2 would be an excellent vehicle for that because we are updating the cache version for that already.

Also, if this does change things that are stored in the cache, we need to update our cloud computed/cached files as well with that? I.e. reindex everything?

ZacLN commented 3 years ago

This does both (so needs new local cache store version + recaching on cloud). It adds a computational cost so my intention had been to merge it at the same time as we disable local caching - is that v1.2?

davidanthoff commented 3 years ago

No, that won't be 1.2, so I removed it from that milestone for now.

davidanthoff commented 3 years ago

@ZacLN Now that we are doing cloud indexing, should we do this?

ZacLN commented 3 years ago

Yep let's do it

davidanthoff commented 3 years ago

@ZacLN Alright, just needs a merge resolve!