turn on get_return_types in indexpackage.jl

julia-vscode / SymbolServer.jl

Other

22 stars 31 forks source link

Closed ZacLN closed 3 years ago

ZacLN commented 3 years ago

Runs inference on all methods when we're caching them (costly)

For every PR, please check the following:

[x] End-user documentation check. If this PR requires end-user documentation in the Julia VS Code extension docs, please add that at https://github.com/julia-vscode/docs.
[x] Changelog mention. If this PR should be mentioned in the CHANGELOG for the Julia VS Code extension, please open a PR against https://github.com/julia-vscode/julia-vscode/blob/master/CHANGELOG.md with those changes.

davidanthoff commented 3 years ago

@ZacLN should we do this now? But do we need to reindex everything then?

ZacLN commented 3 years ago

Let's turn it on. Not necessary to re-cachr everything as no down stream code would be dependent on it.

Caching will become quite a bit more expensive.