Symbol caches: Larger download batching. Don't ask for non-General pkgs

IanButterworth commented 1 year ago

Given non-General packages don't have symbol caches, don't request them, to avoid requesting URLs that include the UUID & name of private packages.

Also the download batching didn't make sense to me. It seems better to limit the concurrent number of downloads, rather than the total number of batches. Update: Now batches of 100

Fixes #.

For every PR, please check the following:

[ ] End-user documentation check. If this PR requires end-user documentation in the Julia VS Code extension docs, please add that at https://github.com/julia-vscode/docs.
[ ] Changelog mention. If this PR should be mentioned in the CHANGELOG for the Julia VS Code extension, please open a PR against https://github.com/julia-vscode/julia-vscode/blob/master/CHANGELOG.md with those changes.

IanButterworth commented 1 year ago

This has proven quite painful to get working on older julia versions. I went as far as 1.1, and for 1.0 rely on a try-catch to default to just generated caches locally. (Perhaps someone else can see a fix for 1.0 where PackageEntry isn't defined?)

IanButterworth commented 1 year ago

@davidanthoff it would be great, if you approve, to get this trialed on the pre-release

pfitzseb commented 10 months ago

Will review/merge this tomorrow. Feel free to ping me somewhere if I don't :)

IanButterworth commented 10 months ago

Will do, thanks

IanButterworth commented 10 months ago

Bump 🙏

pfitzseb commented 10 months ago

Thanks for the PR! I'll make a few follow-up tweaks, but none of that should hold this up any further :)

IanButterworth commented 8 months ago

Just checking, is this used on the extension now? I wasn't sure if the extension uses a non-tagged commit

pfitzseb commented 8 months ago

It is. You can check here which commit the extension uses.

julia-vscode / SymbolServer.jl

Symbol caches: Larger download batching. Don't ask for non-General pkgs #263