search

julia-vscode / SymbolServer.jl

Other
22 stars 31 forks source link

Bugfix: methods added to functions in other packages missing in cache #272

Closed brychcy closed 10 months ago

brychcy commented 10 months ago

This reverts part of commit 50521fb.

Fixes vscode#2565 and the problems related to DataFrames reported in comments to vscode#1576

brychcy commented 10 months ago

Note: After fixing this, I had to delete ~/Library/'Application Support'/Code/User/globalStorage/julialang.language-julia/ (begin o macOS) and restart. Using ">Julia: Re-Index Language Server Cache" was not enough.

brychcy commented 10 months ago

Example code for reproduction: Setup a fresh project, just add "DataFrames". Add a file with the following code:

using DataFrames

x = DataFrame(a=[1, 2])
y = nrow(x)
print(y)

Remove the cache directory mentioned in the previous comment and restart vscode.

A "Possible method call error" error is reported for "nrow". Cmd-Clicking on "nrow" doesn't show a definition.

Now repeat with the patch applied. The errors disappears and, cmd-clicking shows the definitions in DataFrames.