juliabujalski / id-sp17-recipe

This repository contains all the documents and images for EC Interactive Design Recipe Project.
0 stars 0 forks source link

Scoring Rubric #1

Open jgagne opened 7 years ago

jgagne commented 7 years ago

HTML & CSS Recipe To-Dos

20 to-dos, 5 points each; 5 extra credit to-dos

Essential

Code

35 points

Design

40 points

Test

15 points

Git

10 points

Extra Extra

25 points

jgagne commented 7 years ago
jgagne commented 7 years ago
jgagne commented 7 years ago

Include generic font-family fallback… font-family: "Goudy Old Style", Baskerville, serif;

body {
  width: 70%;
  max-width: 60em;
  min-width: 20em;
  margin: auto;
  padding: 0 1em 0 1em;
  color: #300;
  font-family: "Goudy Old Style", Baskerville; 
}
jgagne commented 7 years ago

Use em not cm for screen media. You may use cm or in for print media.

/* Header styling */
header {
  display: block;
  width: 50%;
  text-align: center;
  margin: auto;
  padding: 0 2cm .5cm 2cm;
}
jgagne commented 7 years ago

Please, give your navigation links some horizontal spacing (a bit of a gap to separate).

jgagne commented 7 years ago

p.s. Give those blue links another color or style (please).

jgagne commented 7 years ago

Extra extra: Lowercase filenames (maybe rename? [e.g. holy-cow-step-1.jpg]) https://github.com/juliabujalski/id-sp17-recipe/tree/master/img

jgagne commented 7 years ago

Everything looks great. Consider one last item: