Open jgagne opened 7 years ago
Final Recipe
and Recipe Test
should be lowercase and without spaces. (e.g. recipe-test
, recipe-test-final
, etc.)Include generic font-family fallback…
font-family: "Goudy Old Style", Baskerville, serif;
body {
width: 70%;
max-width: 60em;
min-width: 20em;
margin: auto;
padding: 0 1em 0 1em;
color: #300;
font-family: "Goudy Old Style", Baskerville;
}
Use em
not cm
for screen media. You may use cm
or in
for print media.
/* Header styling */
header {
display: block;
width: 50%;
text-align: center;
margin: auto;
padding: 0 2cm .5cm 2cm;
}
Please, give your navigation links some horizontal spacing (a bit of a gap to separate).
p.s. Give those blue links another color or style (please).
Extra extra: Lowercase filenames (maybe rename? [e.g. holy-cow-step-1.jpg
]) https://github.com/juliabujalski/id-sp17-recipe/tree/master/img
Everything looks great. Consider one last item:
HTML & CSS Recipe To-Dos
20 to-dos, 5 points each; 5 extra credit to-dos
Essential
Code
35 points
class
,id
, and file and folder names should not have spaces, instead use a hyphen-
or an underscore_
in place of a space). For example,<section id="more-recipes">
not<section id="More Recipes">
;main.css
notMain.CSS
header
,nav
,section
, etc.) and semantic text-level elements (strong
,em
,time
, etc.) See HTML5 Doctor’s HTML5 Element Indexpadding
,border
, andmargin
for spacing and rule elementslink
elementrel="canonical"
tocite
original source of recipetitle
and metadescription
Design
40 points
#f03
not#ff0033
)nav
to navigation to page sections (fragments)#ingredients
,#directions
, etc.@media
for wide-to-wider screens, desktop and laptop, layoutinline-block
orfloat
based columns for wide-to-widermax-width: 60em;
layoutTest
15 points
Git
10 points
index.html
css
(folder containing an external style sheet)main.css
orscreen.css
andprint.css
img
(folder containing images)jiffy-cornbread.jpg
versions
(folder [no spaces] containing tests, experiments, work in progress, etc.)recipe-test-1.html
refs
(folder containing images (screen-shots) and/or comps used as style references)style-idea-1.jpg
README.md
; for example https://github.com/mmuench55/quiche-recipeREADME.md
https://username.github.io/repo
→ https://jgagne.github.io/id-sp17-recipe/)Extra Extra
25 points
<figcaption><small class="photo-credit">Photo by Ayanah Proulx</small></figcaption>
#useful
or Color Safe#forlateruse
h1
–h6
) See also heading and section rankExport > Save for Web (Legacy)…
feature by exporting images at a width of960px
using theJPEG High Preset
, and then use ImageOptim to save a few more KB. (Ideal file size per non-retina image should be under200 KB
.)