search

julian-alarcon / prospect-mail

Prospect is an Outlook mail desktop client powered by Electron
MIT License
460 stars 66 forks source link

Fix external link that are 'outlook protected' are opened internal. #262

Closed micw closed 1 year ago

micw commented 1 year ago

This also cleans up the link config so that the JSON and the actual config are identical.

micw commented 1 year ago

fixes #240 for me

fried-eggz commented 1 year ago

Please approve this PR

AdminOfOz commented 1 year ago

I think there is a possibility this would also fix #256. It might also have some overlap with #265

micw commented 1 year ago

Yes, it should also fix #265 and probably #256 - if I know the syntax of a "verification link", I could add it to the list of default external links. (in general, it fixes the "external link" feature, so fixing particula links is just a matter of adding them to the correct list)

jclsn commented 1 year ago

Can someone please merge this? The issue is getting really annoying...

AdminOfOz commented 1 year ago

I checked @julian-alarcon commits and it looks like he is still somewhat active, but not nearly as active as he used to be. Could just be taking it easy for a little while. I think he linked his socials if you want to go as far as ping him on another platform.

Otherwise, I suggest cloning micw's feature branch or merging his changes locally on your computer and running it. It's what I've been doing for awhile now and it works great.

jclsn commented 1 year ago

@the-ryan-1 Okay, thank you. I will see after eastern.

micw commented 1 year ago

Great, thank you. Are you planing a new release soon?