search

julian-alarcon / prospect-mail

Prospect is an Outlook mail desktop client powered by Electron
MIT License
460 stars 66 forks source link

new settings nodeIntegration #312 #314

Open niconil opened 1 year ago

niconil commented 1 year ago

Add this settings to allow correct loading of authentication page when uses JQuery. By default nodeIntegration keeps its true value to not introduce any change. More description in #312 .

8bitZeta commented 1 year ago

This will still fail for me unless contextIsolation: true is removed.

Can you check to see if the changes work for you with that parameter either being set to true or removing it, @niconil?

niconil commented 12 months ago

ok i will modify my pullrequest to add this contextIsolation as a new variable in settings.json file so anyone can adjust its configuration to suit their connection context

niconil commented 11 months ago

ok the pull request is modified you can adjust in settings the value of contextIsolation and/or nodeIntegration

zeitounator commented 11 months ago

Shouldn't contextIsolation be true by default? Having it false currently seems to break many corporate saml login integrations (see https://github.com/julian-alarcon/prospect-mail/issues/312#issuecomment-1869403200)

zeitounator commented 5 months ago

What is the status of this change on your side @julian-alarcon and when do you think you'll get time to review it ? There are several open tickets which would be fixed with this implementation by switching contextIsolation on by default and allowing user to turn it off only for particular situations.

Context isolation is on by default in latest electron releases. Switching it off obviously breaks many corporate SSO login pages using javascript just looking at the different tickets still opened on the subject.

I had to downgrade once again to version 0.4 and upgrade again to latest after my mandatory company password rotation today. Although it's quite easy as demonstrated in my comment on the related issue, this could be fixed for everyone with this PR. I did not see anything broken when I tested.