search

julian-klode / dir2ogg

Official repository of dir2ogg
https://jak-linux.org/projects/dir2ogg/
GNU General Public License v2.0
15 stars 6 forks source link

implemented default behaviour to not overwrite already converted files #3

Closed cwildfoerster closed 3 years ago

cwildfoerster commented 8 years ago

Hi, this fixes my issue #2 dir2ogg now does not re-convert already converted files be default. This behaviour can be overwritten by using the "-o" or "--overwrite" option.

julian-klode commented 8 years ago

Thanks for your pull request. Two points:

(1) I'm not sure -o, --overwrite is a good idea. I'd like to keep -o reserved for an output directory option. Maybe something like -f, --force/--force-overwrite?

(2) Commit message should have a single line summary, followed by an empty line and a long description (all about 60/70 characters long), all written in the present tense, such as:

Do not overwrite already converted files

Add an option --overwrite to allow overwriting already existing files and do not allow overwriting by default.