search

julian-klode / dns66

DNS-based Host Blocker (and lightweight ad blocker) for Android
https://jak-linux.org/projects/dns66/
GNU General Public License v3.0
2.14k stars 200 forks source link

Leanback launcher banner - for Android TV #316

Open stuaxo opened 5 years ago

stuaxo commented 5 years ago

Hi, I'm having a play with leanback launcher on my Android TV. It would be great if it included a banner for the leanback launcher so I could launch DNS 66 through the main interface.

https://developer.nvidia.com/android-tv-developer-guide#leanback_banner

S

stuaxo commented 5 years ago

Addendum:

The "Custom DNS servers" heading, focused state looks the same has unfocused, which makes remote/keyboard navigation a bit more tricky.

stuaxo commented 5 years ago

Addendum 2: I don't think there is a way using only a keyboard (or remote) to do the equivalent of clicking the shield, but maybe it's because it's not possible to see if they are focused or not.

stuaxo commented 5 years ago

The easiest way to test navigability without an Actual Android TV:

Try and use the app using only the following keyboard buttons:

Cursor Keys Enter (for OK) Esc (for Cancel) Backspace (for back)

julian-klode commented 5 years ago

I do have an Android TV, actually; but I don't think I tried running it on there.

julian-klode commented 5 years ago

I tried it on Fire TV, but that became completely useless :)

stuaxo commented 5 years ago

I got it to run ... and it's not useless, but I don't know if it's doing anything - I loaded it to try and block youtube ads and they still occur.

I'll try Firefox and see if ads are blocked.

[EDIT] - By "it" I meant the TV didn't become useless [/EDIT]

hackel commented 5 years ago

FYI, I've been running it on my Nexus Player for over a year now. It works great, but you do need a keyboard/mouse to configure it. Once it's set up, though, it just works. I use DroidMote which sends keyboard/mouse movements from another android device.

stuaxo commented 5 years ago

UX - wise there aren't a huge amount of issues - the colour issue with the top items, and the impossibility of activating the shield icon with the remote/keyboard are the big ones.

hoshsadiq commented 5 years ago

Worth noting that due to a bug in Sony's firmware that they're refusing to fix, this (and any other vpn based apps) may not work and may put your tv in a boot loop if you enable the vpn.

stuaxo commented 5 years ago

@hoshsadiq any idea if there is some way to detect the bug (or just Sony TVs) ?

hoshsadiq commented 5 years ago

Not that I've found. There are a whole bunch of threads around the internet on this, but no concrete solution.

https://github.com/CiNcH83/sony_atv/issues/11 https://github.com/AdguardTeam/AdguardForAndroid/issues/1392 and plenty more but these two are the most interesting threads.

stuaxo commented 5 years ago

Looks like it's possible to get the device name, so maybe a blacklist would be needed if Android TV is supported :/ https://stackoverflow.com/questions/7071281/get-android-device-name