search

julian-klode / dns66

DNS-based Host Blocker (and lightweight ad blocker) for Android
https://jak-linux.org/projects/dns66/
GNU General Public License v3.0
2.11k stars 200 forks source link

fix unit tests and lint errors #442

Closed thromer closed 3 years ago

thromer commented 3 years ago

Fixes #436

codecov-io commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@3f35d6b). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #442   +/-   ##
=======================================
  Coverage        ?   28.60%           
  Complexity      ?      154           
=======================================
  Files           ?       26           
  Lines           ?     1902           
  Branches        ?      229           
=======================================
  Hits            ?      544           
  Misses          ?     1337           
  Partials        ?       21

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3f35d6b...8b719c7. Read the comment docs.

julian-klode commented 3 years ago

I'll have to build and run this at some point, that's a bunch of changes I can't say are safe from looking at it (android:tint -> app:tint being an example), need to validate colors and stuff is correct still. Not sure if you did, but linters are not always right :D

thromer commented 3 years ago

I did not test. No rush. If you prefer I can separate out the lint and unit test changes.

In my set up the build fails due to the lint errors, but that's just a minor annoyance.

On Tue, Apr 13, 2021, 12:00 PM Julian Andres Klode @.***> wrote:

I'll have to build and run this at some point, that's a bunch of changes I can't say are safe from looking at it (android:tint -> app:tint being an example), need to validate colors and stuff is correct still. Not sure if you did, but linters are not always right :D

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/julian-klode/dns66/pull/442#issuecomment-818980458, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABW34GQC42F232UHYBYG743TISIC7ANCNFSM422RM4TA .