julian-klode / dns66

DNS-based Host Blocker (and lightweight ad blocker) for Android
https://jak-linux.org/projects/dns66/
GNU General Public License v3.0
2.14k stars 201 forks source link

DNS66 not blocking any ads. #89

Closed RandomUser202 closed 4 years ago

RandomUser202 commented 7 years ago

I recently installed the app from F-Droid and tried to use it. But once I refreshed the host files, restarted the app and ran it, it didn't work. I tried out a few sites I'll use to test ad blocking such as 4Chan and Forbes and ads still popped up. I disabled any data restricting settings I had on and nothing. Ads still seem to just go through no matter what.

jerryn70 commented 7 years ago

Post the complete link, i will check

arynadam commented 7 years ago

If you are using Chrome, disable browser compression (data saver)..

anoadragon453 commented 7 years ago

screenshot_20170306-002642

I'm using Chromium with DNS66 enabled full-time without data saver and am still getting ads. Here is one ad I found on this page:

https://googleads.g.doubleclick.net/aclk?sa=l&ai=CG95Idxu9WKvBB4zb-QOUhY7ICI_q__1E-8ntoNgEhqe6poUBEAEg9raFAmDJruuGyKOMG6AB-J793APIAQKoAwHIA8kEqgSlAU_QlRbGL84F1T2h3oY04VwLcVG6wXgu1FalUrblYI8q2jF5clbGurNt86dNH4tSeDouZDLjj3-n9P8Jsz_SLLGsvhMumkqtgaSvi5lb95LOkQ4MqZubrs4xR3xrLjQ1o8l4DUVZZe0zzaEPuKx993hepAIQpDR1SgtArgM1RoY3WMx02B0lhk8FJfCO-PCa7AYtjMUKWP1jcUUyFV-qBk1X0Aa9CaAGAtgGAoAH8OCCI6gHpr4b2AcB0ggFCIBhEAE&num=1&sig=AOD64_3sv3l4X_jQXhgZxQjAB-Qa8C8FVg&client=ca-pub-0536483524803400&nm=1&nx=72&ny=193&mb=2&bg=!DQ6lDhZE8Y6YsCsRqdMCAAABVVIAAAAkmQFtDIhGQ2R2SxqCc4wCZP9kXvVvOSX4loVl44-9OrklK2TPfinewnPxEnPOuDIpiA-OLRoO7eRiVSMygtgJuntUC29e9pGp5BvSgh1RcXCXypDldRFWl5kg0qJEK0v1b1w32OxCfzwQM9chudJiNIOUO1xeRJpgjGPDTLNRuBnpaKdrWff7pM1jGjzUNFvGz6TDEDeTrIHLg4zwJxSPqDdOTkdzTGPmQrt5LoLkL4CxS9InXXFxIg3KA31HgbOjeYIpy33DUt3svoHi3Brr-hssPO4A0U72BaCgNC0WIrvxOFo9RbXJUm_jSI6mRxJ9fFZNCtp3BjpXIWCtBi-wxZ9P6vxjSGM_wuwLrkP3cQSUbZIkE-AzoNYb2ghELRe5X7vM_7tmgIRR7r_8zE7_zjbecjzUtCIneVg4tBU-hgcNYCqszQo9CuzcIMpe0vanVbmInGHtTCvOxMcppQ0Ot44I-a5beHgngCPKRbxxgdQ&adurl=http://www.panasas.com/sites/default/files/uploads/docs/storage-manufacturing-buyer-guide.pdf%3Fsrc%3Dweb-cpc

EDIT: I have the following lists enabled:

screenshot_20170306-002839

aggsol commented 7 years ago

I thought lists are active then they are green?!

smed79 commented 7 years ago

You must enable domain filtering & manually update the hosts files (using the refresh button).

dns66 domain filtering

dns66 refresh button

aggsol commented 7 years ago

The color coding is not helpfull. Maybe a Pause and Play icon would be clearer.

julian-klode commented 7 years ago

Guys. The colour is just a hint. You can just click the item and use the spinner if you are unsure.

And the right one to block something is red. Have you never seen a traffic light?

anoadragon453 commented 7 years ago

@julian-klode Thanks for the clarification.

If I have all my lists marked as Deny, how come I still see frequent ads? Do the default lists not block google ads?

julian-klode commented 7 years ago

Nobody can really say. They should be blocked. If the lists are downloaded and marked red, they really should be.

So, maybe Chromium is circumventing DNS66 in some way. The only way to know this is to look at logcat.

Or well, maybe the Google ads domain lookup was cached somewhere from before you started DNS66, and the cache has not expired yet.

anoadragon453 commented 7 years ago

Thanks for the insight. I'll try to get a logcat in the next few days to see what might be the root cause.

My lists should be up to date and I would be surprised if it was a cache issue since I've been running DNS66 for about 3 days straight now.

Hopefully the logs will provide some answers.

On March 6, 2017 1:40:39 AM PST, Julian Andres Klode notifications@github.com wrote:

Nobody can really say. They should be blocked. If the lists are downloaded and marked red, they really should be.

So, maybe Chromium is circumventing DNS66 in some way. The only way to know this is to look at logcat.

Or well, maybe the Google ads domain lookup was cached somewhere from before you started DNS66, and the cache has not expired yet.

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/julian-klode/dns66/issues/89#issuecomment-284347599

smichel17 commented 7 years ago

I am not sure if it is the same issue, but for me, DNS66 stops blocking ads after running for a long time.

julian-klode commented 7 years ago

@smichel17 There should already be more debugging info in the logs than needed :D I guess Android kills it at some point, I've seen it too. But I only notice this a few hours later and reading hours of logcat is painful, even if still existed (there's a limit on the length AFAICT).

smichel17 commented 7 years ago

@smichel17 There should already be more debugging info in the logs than needed :D I guess Android kills it at some point, I've seen it too.

It's kind of odd because when this does happen, the notification (both the system notification about VPN and DNS66's notification, if enabled) is still showing. If DNS66 were killed, I'd expect its notification to be dismissed, or at the least, dismissable.

But I only notice this a few hours later and reading hours of logcat is painful, even if still existed (there's a limit on the length AFAICT).

You could get around this by logging to a db.

julian-klode commented 7 years ago

@smichel17 Ah, if the notification stays on, it's very likely an issue in DNS66. Actually just re-discovered that the whole stops working issue is already tracked in #36. If you can grab a logcat as soon as you notice that this happened, that might be vastly useful.

That said, the reconnecting code might indeed be a bit weird. I assume it's somewhere in there- In the hostdb branch I'm rewriting this (gotta split this out of there, it's unrelated to host db itself; it just does not reconnect there anymore, apparently because we're reconnecting to fast for Android).

MurkBRA commented 7 years ago

just download the last version https://github.com/julian-klode/dns66/releases/latest today is v0.3.1 I download from F-Droid apk form my smartphone and got this old version 0.2.2 and simple don't work...

anoadragon453 commented 7 years ago

I'm on 0.3.0 from F-droid. There doesn't seem to be anything substantial in the point release that would help block ads better. Not sure.

On March 8, 2017 2:43:11 PM PST, MurkBRA notifications@github.com wrote:

just download the last version https://github.com/julian-klode/dns66/releases/latest today is v0.3.1 I download from F-Droid and got this old version 0.2.2 and simple don't work...

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/julian-klode/dns66/issues/89#issuecomment-285194282

RandomUser202 commented 7 years ago

I finally remembered my password for this throwaway account. Anyway, I updated the app and now everything seems to be working just fine. Blocks ads like normal now. Some ahem Not Safe for Work sites seem to slip by but works great none the less.

RandomUser202 commented 7 years ago

Hmm, when I used Naked Browser with DNS66, it seemed to block everything perfectly. Ads slipped through in Chromium.

MurkBRA commented 7 years ago

Like arynadam commented

If you are using Chrome, disable browser compression (data saver)..

anoadragon453 commented 7 years ago

Same thing, getting occasional ads (sometimes they're blocked, sometimes not, VPN on 24/7) in Chromium, data saving disabled.

On March 12, 2017 4:32:09 PM PDT, MurkBRA notifications@github.com wrote:

Like arynadam commented

If you are using Chrome, disable browser compression (data saver)..

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/julian-klode/dns66/issues/89#issuecomment-285986987

smichel17 commented 7 years ago

@anoadragon453 If it is working some of the time, your issue is probably #36, not this.

MurkBRA commented 7 years ago

This addon work with some public list (hosts file) with address of ads but is impossible list all address of internet because she is always growing. you can search for new hosts list or create you own and add some unlisted ads address. I can recomend this here

This repository consolidates several reputable hosts files, and merges them into a unified hosts file with duplicates removed. This repo provides several hosts files tailored to you need to block.

anoadragon453 commented 7 years ago

Battery optimization is and has been off. I will say that testing a few news sites I do not see any ads at the moment.

In my current location the Wi-Fi is sort of spotty and I am switching back and forth between Wi-Fi and LTE frequently, forcing DNS66 to have to keep reconnecting.

I'll monitor for any ads over the news few days and report back if I see any.

On March 12, 2017 4:45:48 PM PDT, smichel17 notifications@github.com wrote:

@anoadragon453 If it is working some of the time, your issue is probably #36, not this.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/julian-klode/dns66/issues/89#issuecomment-285988031

anoadragon453 commented 7 years ago

Yep just got the following ad:

https://adclick.g.doubleclick.net/pcs/click?xai=AKAOjsvvnHh9bBSoq9ae1WEYncTURGSxJ3nqC0sYlapauOfmf9Ac_JrS_6_DNem7HBB2huTYeaqn8BWIygG5ocY5Ap_Bk3DO_6LL2eSRTBs6vaIMPckvYE__26efjKUo&sig=Cg0ArKJSzHhJIkrQ3a-H&urlfix=1&adurl=https://adclick.g.doubleclick.net/pcs/click%3Fxai%3DAKAOjsvD-mC2bmzmvbaVyCwaLnpbtMuId979KrulbGUP5Q_z4M2AUx97FWkaoUxzgn5iZ7209LAMq7EdH2Mq4w4Z9AW79T9kevnw_Lvc-vlwvaB2XJR1YUCNbc-b1yuavxh0mYMfXc3Z4dcuBqxksM8mvPPhHOu4QFgNgIoBUqVEGiPMGnJqWNlX45N5a8m4DHQnGyGzSKZBCAJCL3JXgQCEcDBuhnxcGdRSlYicsSrhUvcvBLhy_6kowomu8yyjnOiFoQ%26sig%3DCg0ArKJSzKM8LEcj1-IqEAE%26urlfix%3D1%26adurl%3Dhttp://www.walmart.com/ip/Listerine-Cool-Mint-Antiseptic-Mouthwash-1.5-L/871623

DNS66 was enabled full time. Got in Chromium Incognito mode on this website: http://www.webmd.com/oral-health/wisdom-tooth-extraction

On March 12, 2017 4:51:50 PM PDT, MurkBRA notifications@github.com wrote:

This addon work with some public list (hosts file) with address of ads but is impossible list all address of internet because she is always growing. you can search for new hosts list or create you own and add some unlisted ads address. I can recomend this here

This repository consolidates several reputable hosts files, and merges them into a unified hosts file with duplicates removed. This repo provides several hosts files tailored to you need to block.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/julian-klode/dns66/issues/89#issuecomment-285988380

RandomUser202 commented 7 years ago

Fuck me, tapped on Close issue by accident.

julian-klode commented 7 years ago

@aggsol While rereading this bug, I read your comment about the play and pause icon. That sort of makes sense. But while play/pause are a nice analogy, they are also fairly confusing: Does a pause icon indicate that stuff is paused, or that is running? For a media player, it would be the latter, but that would not even work in a three-valued toggle.

My initial idea was to use street signs (STOP is a pretty good sign here, as are do-not-enter-style signs). But the "allow" and "ignore" states don't really work that well.

I think there will always be people confused by the icon choice, but at least 0.4 now has a text at the top that explains it.

julian-klode commented 7 years ago

@RandomUser202 @anoadragon453 Please check if it is still a problem with 0.4 when you have time (and it is available on fdroid, if you use f-droid :D). It could be related to some IPv6 changes.

anoadragon453 commented 7 years ago

@julian-klode Thanks Julian, F-droid still offers 0.3.1 in their official repos, though I'll test 0.4 as soon as it's available!

VikSanchez commented 7 years ago

Can we have something like when the device is idle, turn the VPN off to save more charge/power/battery/whatever? Then when you wake it up, the VPN gets automatically turned on (i meant VPN is enabled). I am sure this is possible. Is it too much for an open source or a free app? 😆

smichel17 commented 7 years ago

When I use spotify, I often have my device's screen off, so I would not want DNS66 to stop working then.

VikSanchez commented 7 years ago

But how would the ads bother you if the screen is off?

anoadragon453 commented 7 years ago

Presumably this would just be an option, so the user can choose based on their use case.

On March 28, 2017 6:55:17 PM PDT, VikasDanny notifications@github.com wrote:

But how would the ads bother you if the screen is off?

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/julian-klode/dns66/issues/89#issuecomment-289958481

smichel17 commented 7 years ago

But how would the ads bother you if the screen is off?

Audio ads.

julian-klode commented 7 years ago

Please stop talking about device-off stuff. That is getting out of control, it is entirely irrelevant to this issue. And it's not going to happen anyway. DNS66 requires basically no power (if there are no DNS requests, it is waiting, it's not even running - it waits for the poll() syscall to return). Turning it off and on again will very likely eat a lot resources and save nothing at all.

julian-klode commented 7 years ago

@RandomUser202 @anoadragon453 is this still an issue for you in 0.4 or 0.4.1?

anoadragon453 commented 7 years ago

@julian-klode I actually stopped using the app unfortunately, so not sure.

samhh commented 7 years ago

I installed DNS66 on my partner's phone (unrooted Samsung Note 4 on MM, APK from releases page here) and it didn't seem to have any effect. The service is enabled and I'm 99.9% sure I enabled filtering. Assuming I did, what steps should I take to help debug the issue?

jebeld17 commented 7 years ago

Similar thing here. It is blocking some ads, but not a whole ton... not nearly as many as a paid app like AdGuard.

I think a good way to help implement better ad-blocking is to have a "crowdsourced" mode that enables collection of user-consented blacklists and whitelists to add to future updates for everyone.

(EDIT: see #152)

ponchofiesta commented 7 years ago

Only to keep this up2date. I tried DNS66 yesterday and it blocked nothing for me in Chrome (clean install, data saver disabled). Typically I'm using self compiled Chromium with integrated ad blocking, which blocks ads fine but only in Chromium.

I also tried Virtual Hosts app, which seems to be the same type of app. It also didn't block anything.

muvvag commented 7 years ago

I am using an app - Indian constitution by philoid developers and the dns66 is not blocking ads from the app.

smichel17 commented 7 years ago

@muvvag if some ads are blocked, this is a different issue and you should open a new issue. I'll also preemptively mention, DNS66 blocks based on user-configurable lists. It ships with some default lists, but @julian-klode is not involved in maintaining those lists. That is to say, if the problem is "Some domains are not on the list", it is not a bug with DNS66; the solutions are "add a list with that domain" or "file a bug with the list maintainers so they can add the domain to their list".

@julian-klode I think you should close this issue. It's way too long and contains too many unrelated issues to be useful (not to mention, the original one, caused by app standby and/or doze, is resolved, I think). If there are other outstanding bugs, people can file new issues.

sa7hvik commented 6 years ago

Hi All,

I recently installed dns66 and i am trying to block ads generated by the apps installed not by browsing via chrome or some web browser. Looks like it is not blocking any ads, as ads keeps on popping up every 5 seconds still.

Pls help me in adjusting i could do on Dns66 to block the ads.

Thanks in advance.

Cheers, Sathvik

ghost commented 6 years ago

@sa7hvik Try adding this hosts file to DNS66. http://1hosts.cf

jebeld17 commented 6 years ago

I gave up on the project and went back to AdGuard. It's a paid service, but it works.

smichel17 commented 6 years ago

Unsollicited advertising in a bug tracker feels like pretty poor taste to me.

pm1111 commented 6 years ago

If the problem of ads slipping through isn't caused by DNSSEC it might be caused by DNS over TLS invented by Google and implemented on their name servers. It uses port 853 and is described in RFC 7858

Cassolotl commented 6 years ago

I just installed DNS66, enabled filtering, refreshed to update the lists, enabled ad-blocking in Instagram and Twitter, and ads are still getting through. I restarted my phone and that didn't affect anything. Are there particular lists I need to add to block ads in those apps?

pufferchung commented 6 years ago

DNS66 stopped blocking ads on pixel xl chrome browser after last night's google update

pufferchung commented 6 years ago

By the way, I did try the chrom//flags and clear cache things already, still not working

phoerious commented 6 years ago

For me it stopped working entirely after I upgraded my One Plus to Android 9. I tried reinstalling the app, updated all filter lists, but no ads are blocked at all.