Make `SgfNode::into_builder` non-recursive

julianandrews / sgf-parse

SGF parsing library for Rust.

MIT License

14 stars 3 forks source link

Closed julianandrews closed 3 years ago

julianandrews commented 3 years ago

Right now the implementation is recursive, which means stack overflows could happen for very deep game trees.

In practice, I'm not sure this will ever happen with an SGF from a real game, but it's still wrong in principle!

julianandrews commented 3 years ago

Closing this as irrelevant. See commonts on #14 for more information.