search

julianandrews / sgf-parse

SGF parsing library for Rust.
MIT License
13 stars 3 forks source link

Evaluate handling of faulty files #16

Closed julianandrews closed 3 years ago

julianandrews commented 3 years ago

The spec suggests a few corrections to be made at the bottom of the conversion page.

I should evaluate which of those to accept and how to do that!

julianandrews commented 3 years ago

For the most part, I prefer to leave it to the application developer to decide how they want to handle faulty files. So if a fault doesn't cause an error and doesn't lose any information, I won't try to fix it.

Fixes worth considering:

Properties without values e.g. 'LB B[aa]': remove the property identifiers Files not starting with '(;' e.g. the ';' is missing - this one is tricky if you want to skip junk in front of the SGF file.

For now I'm going to do nothing on this one. It's not obvious to me that those are fixes worth doing.