search

julianandrews / sgf-parse

SGF parsing library for Rust.
MIT License
13 stars 3 forks source link

Add coordinates on the four sides #17

Closed ReneCareenium closed 3 years ago

ReneCareenium commented 3 years ago

For full board diagrams, especially if a user wants to look for the coordinates of a particular spot, having coordinates on the four sides of the board is very helpful. Could this be an option? Thanks!

julianandrews commented 3 years ago

This looks like a good idea!

Also, this looks like an issue in sgf-render (the parser doesn't know anything about board coordinate labels). I've opened up an issue over there to address this. I'll close this issue.

My logic for rendering the labels right now is unfortunately a bit tangled up with the board rendering logic, so it's going to take a bit of a rethink/refactor to do this gracefully, but something like this has been in the back of my head for a while. I added a bunch of tests a couple weeks ago, specifically to make this sort of refactor easier/safer to do, so next time I've got an afternoon to work on this, I'll see about doing this!

ReneCareenium commented 3 years ago

Sorry I got confused and got the wrong project! Thanks for your parser/renderer, they are great :D

julianandrews commented 3 years ago

I'm glad you like them! Starting from version 2.1 you should be able to specify the sides of the board using the --label-sides flag.