Invalid Property Value when parsing

julianandrews / sgf-parse

SGF parsing library for Rust.

MIT License

14 stars 3 forks source link

Invalid Property Value when parsing #8

Closed kurnevsky closed 3 years ago

kurnevsky commented 3 years ago

This game can't be parsed: zagram352562.txt

It's taken from http://eidokropki.reaktywni.pl/index.phtml#url:zagram352562

I guess it's because moves can contain surroundings besides coordinates which is written like W[rp.pmonpoqprpsornqmpm]. According to the spec move is game specific and therefore shouldn't be parsed for unknown games.

Also spec says that invalid properties should be corrected or ignored.

julianandrews commented 3 years ago

Sorry for the slow reply on this - my notification settings are a little off in github. I've split this into two issues that are more on point. Please comment on either if you have thoughts about the proposed fixes!

julianandrews commented 3 years ago

I'm going to close this issue since the fix for #10 should also fix the immediate problem here. Leaving #9 open for if/when I have time to figure out the best approach.