juliancwirko / elrond-nft-minting-platform-poc

Elrond NFT minting platform POC (Also check out: www.elven.tools)
https://elrond-nft-minting-platform-poc.netlify.app/
12 stars 11 forks source link

fix: use TransactionPayloadBuilder instead of raw #1

Open victordrnd opened 2 years ago

victordrnd commented 2 years ago

Description

Use of erdjs ContractCallPayloadBuilder instead raw string payload causing conflict when bytes are not even.

Type of change

juliancwirko commented 2 years ago

Hi, thanks for the contribution. Can I test it, or will you be working on it further?

victordrnd commented 2 years ago

Hi, Yes you can test it, I may be upgrading some other stuff but not on this branch

Le jeu. 6 janv. 2022 à 10:58, Julian Ćwirko @.***> a écrit :

Hi, thanks for the contribution. Can I test it, or will you be working on it further?

— Reply to this email directly, view it on GitHub https://github.com/juliancwirko/elven-tools/pull/1#issuecomment-1006429093, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFIW3BHWKEMLCOFTCQTTMNTUUVRTHANCNFSM5LDSHTCA . You are receiving this because you authored the thread.

juliancwirko commented 2 years ago

I can't add comments in the code, don't know why, but anyway, it should be: .setFunction(new ContractFunction("issueNonFungible")) instead issueSemiFungible

victordrnd commented 2 years ago

Oh yes sorry, bad copy paste

On Fri, Jan 7, 2022 at 10:44 AM Julian Ćwirko @.***> wrote:

I can't add comments in the code, don't know why, but anyway, it should be: .setFunction(new ContractFunction("issueNonFungible")) instead issueSemiFungible

— Reply to this email directly, view it on GitHub https://github.com/juliancwirko/elven-tools/pull/1#issuecomment-1007269824, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFIW3BDSFTTNGPX4I6WCOY3UU2YXJANCNFSM5LDSHTCA . You are receiving this because you authored the thread.Message ID: @.***>