search

julianghionoiu / dpnt-coverage

Collect coverage from SRCS files
0 stars 0 forks source link

Updated the python Dockerfile with new updates #30

Closed neomatrix369 closed 5 years ago

neomatrix369 commented 5 years ago

Updated the python Dockerfile with new updates, fixing the previously broken version, using multi-stage builds

This work is come about whilst working on https://github.com/julianghionoiu/tdl-runner-python/pull/5

julianghionoiu commented 5 years ago

I am trying to understand why do we need all these changes?

Would you be able to give me more info.

neomatrix369 commented 5 years ago

@julianghionoiu I mentioned on this thread https://github.com/julianghionoiu/tdl-runner-python/issues/4#issuecomment-446796016 what was happening when I tried to build the base image and the python image on top of it.

Do you experience the same or it builds for you? It does not build for me, and I think out base image needs fixing in that case.

Hence we need the changes I have in this PR - I'm testing the code coverage for Python, once we finish with the test, we can choose to change this PR the way it suits us.

But for now the original Dockerfile config does not help us.

If your question is about whats in this Dockerfile, I can explain in a separate message about it.

neomatrix369 commented 5 years ago 
~~~ Summary of test executions ~~~
  ~~~ Passed Tests ~~~
  language=python|challenge=SUM|expected=100|actual=100
  language=python|challenge=TST|expected=50|actual=50
  language=python|challenge=CHK|expected=0|actual=0
  language=python|challenge=xyz|expected=0|actual=0
  4 test(s) passed

  ~~~ Failed Tests ~~~
  0 test(s) failed
julianghionoiu commented 5 years ago

There is no need for this. The issue was in the requirements.txt syntax. I have removed the conditionals and pinned it to the lower version. We currently suggest Python2X to the candidate. There is a separate story to transition everything to Python3.