julianghionoiu / tdl-lord-of-runners

One repo to rule them all, One repo to configure them, One repo to bring them all and in the darkness bind them
GNU General Public License v3.0
0 stars 0 forks source link

Applied fix to record_screen_and_update: Java 11 and 12 missing modules issue fix #8

Closed neomatrix369 closed 5 years ago

neomatrix369 commented 5 years ago

Applied fix to record_screen_and_update Linux/MacOS and Windows scripts to overcome modules issue starting Java 11

Fix for issue https://github.com/julianghionoiu/record-and-upload/issues/7

Test results

Linux Java 8 - Linux

± ./record_screen_and_upload.sh
---> Pre-Java 9 detected <---
Using DEFAULT_JVM_OPTS variable with value ''
--------------------------------------------------------------------------------------------------------------
INFO  [main]       - Starting recording app
INFO  [main]       - Checking permissions
INFO  [main]       - Logging initialized @1583ms to org.eclipse.jetty.util.log.Slf4jLog
Java HotSpot(TM) 64-Bit Server VM warning: You have loaded library /tmp/humble2532518685419305331.tmp which might have disabled stack guard. The VM will try to fix the stack guard now.
It's highly recommended that you fix the library with 'execstack -c <libfile>', or link it with '-z noexecstack'.
INFO  [VideoRec]   - Open the input stream
INFO  [Upload]     - Sync local files with remote
INFO  [main]       - jetty-9.4.7.v20170914
INFO  [VideoRec]   - Start recording to "screencast_20181117T203434.mp4" at 16 fps with 4 screenshots/sec
INFO  [main]       - Started ServerConnector@654d8173{HTTP/1.1,[http/1.1]}{localhost:41375}
INFO  [main]       - Started @3524ms
INFO  [SourceRec]  - Start recording to "sourcecode_20181117T203434.srcs"
INFO  [Upload]     - Uploading file record/localstore/record-and-upload-20181117T203433.log
INFO  [Upload]     - Finished uploading file record/localstore/record-and-upload-20181117T203433.log
INFO  [Upload]     - Uploading file record/localstore/record-and-upload-20181117T202625.log
INFO  [main]       - ~~~~~~ Stopped ~~~~~~

Java 9 - Linux

± go9
Switched to /usr/lib/jvm/jdk-9.0.1

satyasai at sai-XPS-15-9560 in ~/git-repos/BeFaster/tdl-runner-java on master!

± ./record_screen_and_upload.sh
---> Java 9 or higher detected (version 9) <---
Adding JVM args to the DEFAULT_JVM_OPTS variable, new value set to '--illegal-access=warn  --add-modules=java.xml.bind,java.activation  '
--------------------------------------------------------------------------------------------------------------
WARNING: Illegal reflective access by Capsule (file:/home/satyasai/git-repos/BeFaster/tdl-runner-java/record/record-and-upload-capsule.jar) to field com.sun.jmx.mbeanserver.JmxMBeanServer.mbsInterceptor
WARNING: Illegal reflective access by Capsule (file:/home/satyasai/git-repos/BeFaster/tdl-runner-java/record/record-and-upload-capsule.jar) to field java.lang.ProcessImpl.pid
INFO  [main]       - Starting recording app
INFO  [main]       - Checking permissions
INFO  [main]       - Logging initialized @1646ms to org.eclipse.jetty.util.log.Slf4jLog
Java HotSpot(TM) 64-Bit Server VM warning: You have loaded library /tmp/humble14984434904339375879.tmp which might have disabled stack guard. The VM will try to fix the stack guard now.
It's highly recommended that you fix the library with 'execstack -c <libfile>', or link it with '-z noexecstack'.
INFO  [VideoRec]   - Open the input stream
INFO  [Upload]     - Sync local files with remote
INFO  [main]       - jetty-9.4.7.v20170914
INFO  [main]       - Started ServerConnector@1976f537{HTTP/1.1,[http/1.1]}{localhost:41375}
INFO  [main]       - Started @3224ms
INFO  [SourceRec]  - Start recording to "sourcecode_20181117T203448.srcs"
INFO  [main]       - ~~~~~~ Stopped ~~~~~~

Java 10 - Linux

± go10
Switched to /usr/lib/jvm/jdk-10.0.1

satyasai at sai-XPS-15-9560 in ~/git-repos/BeFaster/tdl-runner-java on master!

± ./record_screen_and_upload.sh
---> Java 9 or higher detected (version 10) <---
Adding JVM args to the DEFAULT_JVM_OPTS variable, new value set to '--illegal-access=warn  --add-modules=java.xml.bind,java.activation  '
--------------------------------------------------------------------------------------------------------------
WARNING: Illegal reflective access by Capsule (file:/home/satyasai/git-repos/BeFaster/tdl-runner-java/record/record-and-upload-capsule.jar) to field com.sun.jmx.mbeanserver.JmxMBeanServer.mbsInterceptor
WARNING: Illegal reflective access by Capsule (file:/home/satyasai/git-repos/BeFaster/tdl-runner-java/record/record-and-upload-capsule.jar) to field java.lang.ProcessImpl.pid
INFO  [main]       - Starting recording app
INFO  [main]       - Checking permissions
INFO  [main]       - Logging initialized @1753ms to org.eclipse.jetty.util.log.Slf4jLog
Java HotSpot(TM) 64-Bit Server VM warning: You have loaded library /tmp/humble17437479209422854003.tmp which might have disabled stack guard. The VM will try to fix the stack guard now.
It's highly recommended that you fix the library with 'execstack -c <libfile>', or link it with '-z noexecstack'.
INFO  [VideoRec]   - Open the input stream
INFO  [Upload]     - Sync local files with remote
INFO  [main]       - jetty-9.4.7.v20170914
INFO  [main]       - Started ServerConnector@1976f537{HTTP/1.1,[http/1.1]}{localhost:41375}
INFO  [main]       - Started @3315ms
INFO  [SourceRec]  - Start recording to "sourcecode_20181117T211118.srcs"
INFO  [VideoRec]   - Start recording to "screencast_20181117T211118.mp4" at 16 fps with 4 screenshots/sec
INFO  [main]       - ~~~~~~ Stopped ~~~~~~

Java 11 - Linux

± go11                         
Switched to /usr/lib/jvm/jdk-11

satyasai at sai-XPS-15-9560 in ~/git-repos/BeFaster/tdl-runner-java on master!

± ./record_screen_and_upload.sh
---> Java 9 or higher detected (version 11) <---
Using DEFAULT_JVM_OPTS variable with value ''
Not using kill-switch or modules flags starting from this version of Java
--------------------------------------------------------------------------------------------------------------
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by Capsule (file:/home/satyasai/git-repos/BeFaster/tdl-runner-java/record/record-and-upload-capsule.jar) to field com.sun.jmx.mbeanserver.JmxMBeanServer.mbsInterceptor
WARNING: Please consider reporting this to the maintainers of Capsule
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
INFO  [main]       - Starting recording app
INFO  [main]       - Checking permissions
INFO  [main]       - Logging initialized @1350ms to org.eclipse.jetty.util.log.Slf4jLog
Java HotSpot(TM) 64-Bit Server VM warning: You have loaded library /tmp/humble15968755947215289552.tmp which might have disabled stack guard. The VM will try to fix the stack guard now.
It's highly recommended that you fix the library with 'execstack -c <libfile>', or link it with '-z noexecstack'.
INFO  [VideoRec]   - Open the input stream
INFO  [Upload]     - Sync local files with remote
INFO  [main]       - jetty-9.4.7.v20170914
INFO  [main]       - Started ServerConnector@5b84f14{HTTP/1.1,[http/1.1]}{localhost:41375}
INFO  [main]       - Started @2924ms
INFO  [SourceRec]  - Start recording to "sourcecode_20181117T203508.srcs"
INFO  [VideoRec]   - Start recording to "screencast_20181117T203508.mp4" at 16 fps with 4 screenshots/sec
INFO  [main]       - ~~~~~~ Stopped ~~~~~~

Java 12 - Linux

± go12
Switched to /usr/lib/jvm/jdk-12

± ./record_screen_and_upload.sh
---> Java 9 or higher detected (version 12) <---
Using DEFAULT_JVM_OPTS variable with value ''
Not using kill-switch or modules flags starting from this version of Java
--------------------------------------------------------------------------------------------------------------
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by Capsule (file:/home/satyasai/git-repos/BeFaster/tdl-runner-java/record/record-and-upload-capsule.jar) to field com.sun.jmx.mbeanserver.JmxMBeanServer.mbsInterceptor
WARNING: Please consider reporting this to the maintainers of Capsule
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
INFO  [main]       - Starting recording app
INFO  [main]       - Checking permissions
INFO  [main]       - Logging initialized @1408ms to org.eclipse.jetty.util.log.Slf4jLog
OpenJDK 64-Bit Server VM warning: You have loaded library /tmp/humble1574203657850087751.tmp which might have disabled stack guard. The VM will try to fix the stack guard now.
It's highly recommended that you fix the library with 'execstack -c <libfile>', or link it with '-z noexecstack'.
INFO  [VideoRec]   - Open the input stream
INFO  [Upload]     - Sync local files with remote
INFO  [main]       - jetty-9.4.7.v20170914
INFO  [main]       - Started ServerConnector@26f96b85{HTTP/1.1,[http/1.1]}{localhost:41375}
INFO  [main]       - Started @3738ms
INFO  [SourceRec]  - Start recording to "sourcecode_20181117T205033.srcs"
INFO  [Upload]     - Uploading file record/localstore/record-and-upload-20181117T205032.record/localstore/sourcecode_20181117T205033.srcs
INFO  [main]       - ~~~~~~ Stopped ~~~~~~

Windows Java 8 - Windows

JAVA_EXE=C:\PROGRA~1\Java\JDK18~1.0_1\bin\java.exe

D:\tdl-runner-java>for /F "tokens=3" %g in ('C:\PROGRA~1\Java\JDK18~1.0_1\bin\java.exe -version 2>&1 | findstr /i "version"') do (set JAVA_FULL_VERSION=%g )

D:\tdl-runner-java>(set JAVA_FULL_VERSION="1.8.0_181" )

JAVA_FULL_VERSION=1.8.0_181

JAVA_VERSION=8
"--- Pre-Java 9 detected ---"
"Using DEFAULT_JVM_OPTS variable with value ''"
"--------------------------------------------------------------------------------------------------------------"

D:\tdl-runner-java>"C:\PROGRA~1\Java\JDK18~1.0_1\bin\java.exe"    -jar "D:\tdl-runner-java\\record\record-and-upload-capsule.jar" --config D:\tdl-runner-java\\config\credentials.config --store D:\tdl-runner-java\\record\localstore --sourcecode D:\tdl-runner-java\
INFO  [main]       - Starting recording app
INFO  [main]       - Checking permissions
INFO  [main]       - Logging initialized @4374ms to org.eclipse.jetty.util.log.Slf4jLog
INFO  [VideoRec]   - Open the input stream
INFO  [Upload]     - Sync local files with remote
INFO  [main]       - jetty-9.4.7.v20170914
INFO  [SourceRec]  - Start recording to "sourcecode_20181117T211639.srcs"
INFO  [Metrics]    -  0 source capture,   0 ms/capture
INFO  [Metrics]    -  0 source capture,   0 ms/capture
INFO  [main]       - Started ServerConnector@7894f09b{HTTP/1.1,[http/1.1]}{localhost:41375}
INFO  [main]       - Started @45459ms
INFO  [VideoRec]   - Start recording to "screencast_20181117T211639.mp4" at 16 fps with 4 screenshots/sec
INFO  [Upload]     - Uploading file record/localstore/record-and-upload-20181117T211638.log
INFO  [Upload]     - Finished uploading file record/localstore/record-and-upload-20181117T211638.log
INFO  [Upload]     - Uploading file record/localstore/sourcecode_20181117T211639.srcs
INFO  [Upload]     - Finished uploading file record/localstore/sourcecode_20181117T211639.srcs
INFO  [main]       - ~~~~~~ Stopped ~~~~~~

Java 9 - Windows

D:\tdl-runner-java>record_screen_and_upload.bat

Displaying operating system specific systeminfo...
OS Name:                   Microsoft Windows 10 Enterprise Evaluation
OS Version:                10.0.17134 N/A Build 17134
OS Manufacturer:           Microsoft Corporation
OS Configuration:          Standalone Workstation
OS Build Type:             Multiprocessor Free
BIOS Version:              innotek GmbH VirtualBox, 01-Dec-06

JAVA_HOME=C:\PROGRA~1\Java\JDK-90~1.4

JAVA_EXE=C:\PROGRA~1\Java\JDK-90~1.4\bin\java.exe

D:\tdl-runner-java>for /F "tokens=3" %g in ('C:\PROGRA~1\Java\JDK-90~1.4\bin\java.exe -version 2>&1 | findstr /i "version"') do (set JAVA_FULL_VERSION=%g )

D:\tdl-runner-java>(set JAVA_FULL_VERSION="9.0.4" )

JAVA_FULL_VERSION=9.0.4

JAVA_VERSION=9
"--- Java 9 or higher detected (version 9) ---"
"Adding JVM args to the DEFAULT_JVM_OPTS variable, new value set to ''"
"--------------------------------------------------------------------------------------------------------------"

D:\tdl-runner-java>"C:\PROGRA~1\Java\JDK-90~1.4\bin\java.exe" --illegal-access=warn --add-modules=java.xml.bind,java.activation    -jar "D:\tdl-runner-java\\record\record-and-upload-capsule.jar" --config D:\tdl-runner-java\\config\credentials.config --store D:\tdl-runner-java\\record\localstore --sourcecode D:\tdl-runner-java\
WARNING: Illegal reflective access by Capsule (file:/D:/tdl-runner-java/record/record-and-upload-capsule.jar) to field com.sun.jmx.mbeanserver.JmxMBeanServer.mbsInterceptor
INFO  [main]       - Starting recording app
INFO  [main]       - Checking permissions
INFO  [main]       - Logging initialized @1907ms to org.eclipse.jetty.util.log.Slf4jLog

Java 10 - Windows

D:\tdl-runner-java>record_screen_and_upload.bat

Displaying operating system specific systeminfo...
OS Name:                   Microsoft Windows 10 Enterprise Evaluation
OS Version:                10.0.17134 N/A Build 17134
OS Manufacturer:           Microsoft Corporation
OS Configuration:          Standalone Workstation
OS Build Type:             Multiprocessor Free
BIOS Version:              innotek GmbH VirtualBox, 01-Dec-06

JAVA_HOME=C:\PROGRA~1\Java\JRE-10~1.2

JAVA_EXE=C:\PROGRA~1\Java\JRE-10~1.2\bin\java.exe

D:\tdl-runner-java>for /F "tokens=3" %g in ('C:\PROGRA~1\Java\JRE-10~1.2\bin\java.exe -version 2>&1 | findstr /i "version"') do (set JAVA_FULL_VERSION=%g )

D:\tdl-runner-java>(set JAVA_FULL_VERSION="10.0.2" )

JAVA_FULL_VERSION=10.0.2

JAVA_VERSION=10
"--- Java 9 or higher detected (version 10) ---"
"Adding JVM args to the DEFAULT_JVM_OPTS variable, new value set to ''"
"--------------------------------------------------------------------------------------------------------------"

D:\tdl-runner-java>"C:\PROGRA~1\Java\JRE-10~1.2\bin\java.exe" --illegal-access=warn --add-modules=java.xml.bind,java.activation    -jar "D:\tdl-runner-java\\record\record-and-upload-capsule.jar" --config D:\tdl-runner-java\\config\credentials.config --store D:\tdl-runner-java\\record\localstore --sourcecode D:\tdl-runner-java\
WARNING: Illegal reflective access by Capsule (file:/D:/tdl-runner-java/record/record-and-upload-capsule.jar) to field com.sun.jmx.mbeanserver.JmxMBeanServer.mbsInterceptor
INFO  [main]       - Starting recording app
INFO  [main]       - Checking permissions
INFO  [main]       - Logging initialized @2112ms to org.eclipse.jetty.util.log.Slf4jLog
INFO  [VideoRec]   - Open the input stream
INFO  [Upload]     - Sync local files with remote
INFO  [main]       - jetty-9.4.7.v20170914
INFO  [SourceRec]  - Start recording to "sourcecode_20181117T205635.srcs"
INFO  [Metrics]    -  0 source capture,   0 ms/capture
INFO  [main]       - Started ServerConnector@499683c4{HTTP/1.1,[http/1.1]}{localhost:41375}
INFO  [main]       - Started @11619ms
INFO  [VideoRec]   - Start recording to "screencast_20181117T205635.mp4" at 16 fps with 4 screenshots/sec
INFO  [Metrics]    - Recorded 0h00m00s,   0 frame, 0.00 MB |  0 source capture,   0 INFO  [main]       - Finished uploading file record/localstore/sourcecode_20181117T205635.srcs
INFO  [main]       - ~~~~~~ Stopped ~~~~~~

Java 11 - Windows

D:\tdl-runner-java>record_screen_and_upload.bat

Displaying operating system specific systeminfo...
OS Name:                   Microsoft Windows 10 Enterprise Evaluation
OS Version:                10.0.17134 N/A Build 17134
OS Manufacturer:           Microsoft Corporation
OS Configuration:          Standalone Workstation
OS Build Type:             Multiprocessor Free
BIOS Version:              innotek GmbH VirtualBox, 01-Dec-06

JAVA_HOME=C:\PROGRA~1\Java\JDK-11~1.1

JAVA_EXE=C:\PROGRA~1\Java\JDK-11~1.1\bin\java.exe

D:\tdl-runner-java>for /F "tokens=3" %g in ('C:\PROGRA~1\Java\JDK-11~1.1\bin\java.exe -version 2>&1 | findstr /i "version"') do (set JAVA_FULL_VERSION=%g )

D:\tdl-runner-java>(set JAVA_FULL_VERSION="11.0.1" )

JAVA_FULL_VERSION=11.0.1

JAVA_VERSION=11
"--- Java 9 or higher detected (version 11) ---"
"Using DEFAULT_JVM_OPTS variable with value ''"
"Not using kill-switch or modules flags starting from this version of Java"
"--------------------------------------------------------------------------------------------------------------"

D:\tdl-runner-java>"C:\PROGRA~1\Java\JDK-11~1.1\bin\java.exe"    -jar "D:\tdl-runner-java\\record\record-and-upload-capsule.jar" --config D:\tdl-runner-java\\config\credentials.config --store D:\tdl-runner-java\\record\localstore --sourcecode D:\tdl-runner-java\
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by Capsule (file:/D:/tdl-runner-java/record/record-and-upload-capsule.jar) to field com.sun.jmx.mbeanserver.JmxMBeanServer.mbsInterceptor
WARNING: Please consider reporting this to the maintainers of Capsule
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
INFO  [main]       - Starting recording app
INFO  [main]       - Checking permissions
INFO  [main]       - Logging initialized @2100ms to org.eclipse.jetty.util.log.Slf4jLog
INFO  [VideoRec]   - Open the input stream
INFO  [Upload]     - Sync local files with remote
INFO  [main]       - jetty-9.4.7.v20170914
INFO  [VideoRec]   - Start recording to "screencast_20181117T211939.mp4" at 16 fps with 4 screenshots/sec
INFO  [main]       - Started ServerConnector@7c551ad4{HTTP/1.1,[http/1.1]}{localhost:41375}
INFO  [main]       - Started @8492ms
INFO  [main]       - ~~~~~~ Stopped ~~~~~~

Java 12 - Windows

D:\tdl-runner-java>record_screen_and_upload.bat

Displaying operating system specific systeminfo...
OS Name:                   Microsoft Windows 10 Enterprise Evaluation
OS Version:                10.0.17134 N/A Build 17134
OS Manufacturer:           Microsoft Corporation
OS Configuration:          Standalone Workstation
OS Build Type:             Multiprocessor Free
BIOS Version:              innotek GmbH VirtualBox, 01-Dec-06

JAVA_HOME=C:\PROGRA~1\Java\jdk-12

JAVA_EXE=C:\PROGRA~1\Java\jdk-12\bin\java.exe

D:\tdl-runner-java>for /F "tokens=3" %g in ('C:\PROGRA~1\Java\jdk-12\bin\java.exe -version 2>&1 | findstr /i "version"') do (set JAVA_FULL_VERSION=%g )

D:\tdl-runner-java>(set JAVA_FULL_VERSION="12-ea" )

JAVA_FULL_VERSION=12-ea

JAVA_VERSION=12
"--- Java 9 or higher detected (version 12) ---"
"Using DEFAULT_JVM_OPTS variable with value ''"
"Not using kill-switch or modules flags starting from this version of Java"
"--------------------------------------------------------------------------------------------------------------"

D:\tdl-runner-java>"C:\PROGRA~1\Java\jdk-12\bin\java.exe"    -jar "D:\tdl-runner-java\\record\record-and-upload-capsule.jar" --config D:\tdl-runner-java\\config\credentials.config --store D:\tdl-runner-java\\record\localstore --sourcecode D:\tdl-runner-java\
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by Capsule (file:/D:/tdl-runner-java/record/record-and-upload-capsule.jar) to field com.sun.jmx.mbeanserver.JmxMBeanServer.mbsInterceptor
WARNING: Please consider reporting this to the maintainers of Capsule
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
INFO  [main]       - Starting recording app
INFO  [main]       - Checking permissions
INFO  [main]       - Logging initialized @1645ms to org.eclipse.jetty.util.log.Slf4jLog
INFO  [VideoRec]   - Open the input stream
INFO  [VideoRec]   - Start recording to "screencast_20181117T204818.mp4" at 16 fps with 4 screenshots/sec
INFO  [Upload]     - Sync local files with remote
INFO  [Metrics]    - Recorded 0h00m00s,   0 frame, 0.00 MB
INFO  [main]       - jetty-9.4.7.v20170914
INFO  [main]       - Started ServerConnector@29a4f594{HTTP/1.1,[http/1.1]}{localhost:41375}
INFO  [main]       - Started @10115ms
INFO  [main]       - ~~~~~~ Stopped ~~~~~~
julianghionoiu commented 5 years ago

Looks good. Let me roll out the new version of the Jar file and then merge and release this.