phantomjs processes aren't killed correctly

juliangruber / browser-run

Run code inside a browser from the command line

447 stars 62 forks source link

phantomjs processes aren't killed correctly #2

Closed ashnur closed 9 years ago

ashnur commented 11 years ago

After running it many times, I observed that unclosed processed are piling up.

Running ps aux | grep node returned a lot of these:

ashnur    5010  0.0  0.4 1384812 17308 pts/5   Sl   10:43   0:00 /usr/lib/node_modules/mocha-run/node_modules/browser-run/node_modules/phantomjs/lib/phantom/bin/phantomjs /usr/lib/node_modules/mocha-run/node_modules/browser-run/script/run.js 60492

juliangruber commented 10 years ago

I keep seeing this problem in other projects too, but I don't yet know how to fix this

ashnur commented 10 years ago

Last time I was told they just regularly kill the processes.

juliangruber commented 9 years ago

the new version using electron fixes a lot of issues, this should be gone