Faster implementation - Githubissues

juliangruber / intersect

Find the intersection of two arrays

MIT License

32 stars 8 forks source link

Open lovasoa opened 5 years ago

lovasoa commented 5 years ago

In case you are interested, I just published a faster implementation of the same algorithm: lovasoa/fast_array_intersect.

Here are the things you could improve in your version :

Fill the initial map using the smallest of the arrays, not the first
iterate over arrays using for(var i=0; i<a.length; i++) instead of for(var i in a)
implement a premature stopping condition as soon as the intersection is empty
(only in ES6) use a Map instead of an object

juliangruber commented 5 years ago

Awesome! Thanks for sharing your insights :) I'm going to keep this issue open for anyone to learn, discover your version of pick up working on it 🙏