search

juliangruber / level-list

Map lists of data stored in a LevelDB to DOM elements.
7 stars 1 forks source link

Binary key could potentially create duplicates #6

Closed morganrallen closed 10 years ago

morganrallen commented 10 years ago

DIdn't notice id was being assigned back to _key. This could cause entry duplication.

juliangruber commented 10 years ago

this changes the api to row.value too, we wouldn't want to do this without updating the docs and examples. Could you slim down this pull request to only contain the fix for duplicates and open another one for the .value refactor?

morganrallen commented 10 years ago

OK, think that should work, I'll open a new ticket with the other change and we can discuss it furter.

juliangruber commented 10 years ago

if you look at the files changed tab this is only a merge commit

morganrallen commented 10 years ago

Not sure I follow, I see diff stats and changes...

juliangruber commented 10 years ago

https://github.com/juliangruber/level-list/pull/6/files i don't see anything new

morganrallen commented 10 years ago

Hmmph...

morganrallen commented 10 years ago

okay... not sure what's going on here, I will kill this and create a clean pull request.

juliangruber commented 10 years ago

no worries :)