julianh2o / RokuAlexaLambdaSkill

An Alexa Skill that allows voice control of your Roku
MIT License
104 stars 55 forks source link

Pull request for a lot of changes and step-by-step guide #9

Closed chris1642 closed 7 years ago

julianh2o commented 7 years ago

Hey Chris,

Is there any particular reason that you've changed the name of the root folders: "RokuLambda" "RokuControlServer" and "RokuSkill"?

It can make the merge pretty difficult to perform diligently when you have both changes and major renames at the same time.

I'm willing to rename these directories if you make a good case for it, but ideally this would happen separate from the changes in functionality. (if for no other reason than clarity)

I'm going to review the diff list without these renames and probably make some minor tweaks (like omitting your local IP address)

julianh2o commented 7 years ago

I've merged some changes with some significant changes.. some commentary..

Otherwise, thanks for the input! I've added you to the contributors and have merged your changes in!

chris1642 commented 7 years ago

In terms of changing the folder names....that was more me being lazy. I had it changed on my desktop and once I realized github took them as is, I never went to edit the folder names.

The IP and app ID should be both made up. I just randomly replaced keys on my original so people would see an example within the guide.

Haven't looked at your code change for the downtwo example, but very glad to hear there is a way of making better! As you can see, I certainly am no programmer - I am merely decent at seeing how something works and duplicating/expanding a bit. Creating is a different aspect :)