search

julianharty / testing-heuristics

Experiments to see if we can establish evidence of the value of testing heuristics
MIT License
3 stars 0 forks source link

Engineering Enhancement: Build and Clean scripts #19

Closed julianharty closed 7 years ago

julianharty commented 7 years ago

We're getting close to the stage where it'd be good to have repeatable ways to create a faithful build without extraneous or old files.

To create a ZIM file we need an icon.png and currently I'm also creating a copy of style.css in a new folder ./A/ so the stylesheet is correctly applied in the ZIM content (this may be addressed separately at some point).

Implementation ideas

We currently use npm start to create the distribution. Could we enhance this to:

  1. clean the ./dist folder,
  2. copy the icon.png,
  3. copy Google Analytics Javascript (currently in ./include),
  4. create ./dist/A/ and duplicate the CSS file style.css into this folder (symlinks cause problems for zimwriterfs (See https://github.com/openzim/libzim/issues/16 and https://github.com/openzim/zimwriterfs/issues/3)
ISNIT0 commented 7 years ago

I don't see a ./include, what do you mean by that?

julianharty commented 7 years ago

Sorry for mentioned it before I'd committed it. I've just done so. https://github.com/julianharty/testing-heuristics/commit/47028fe771961c502096b8204d17a3f51b30a425

julianharty commented 7 years ago

I believe we've addressed this enhancement, so I'll close this issue. Thanks for your help.