search

julianhille / MuhammaraJS

Muhammara a node module with c/cpp bindings to modify PDF with js for node or electron (based/replacement on/of galkhana/hummusjs)
Other
229 stars 46 forks source link

Add option for annotation replies #314

Closed joemoongit closed 11 months ago

joemoongit commented 1 year ago

Creating a draft pr for now. Still need to write test cases and may make modifications.

julianhille commented 1 year ago

Are you fine when i run ci after v4 release?

joemoongit commented 1 year ago

yes

julianhille commented 1 year ago

damn also needs rebasing to be able to run in CI

joemoongit commented 1 year ago

i’ve marked this pull request as ready. the annotation replies are working and they show up on pdfs. i've also updated how the annotations show up for the function text(). there are some more options we can add (i have commented them out for now) and optimizations we could make, but i will handle it in another pr, if that is okay with you. we could also add support for other types of annotations in later PRs.

julianhille commented 1 year ago

will try this evening or tomorrow to get back to it, please remind me if i do not do this. sorry for the inconveniences

joemoongit commented 1 year ago

do you have any suggestions? are you ok with the naming of some of the new variables such as 'replies' in AnnotOptions? also are you ok with me making some refactors/additions in later PRs?

julianhille commented 1 year ago

Do you want me to wait requested changes?

joemoongit commented 1 year ago

i will get back to you after this weekend. apologies for the delay

joemoongit commented 11 months ago

i've made some updates to the options for annotation replies. it appears that the 'open' and 'icon' keys only pertain to text annotations of which are not replies. i've updated the documentation and test cases as well