search

julianhille / MuhammaraJS

Muhammara a node module with c/cpp bindings to modify PDF with js for node or electron (based/replacement on/of galkhana/hummusjs)
Other
205 stars 43 forks source link

TypeScript errors - make input optional #320

Open mchepel opened 11 months ago

mchepel commented 11 months ago

capture Should getSourceDocumentParser require "input" parameter?

getSourceDocumentParser( input: FilePath | ReadStream, options?: PDFReaderOptions ): PDFReader;

It seems it may not be required

PDFParser* PDFDocumentHandler::GetSourceDocumentParser() { return mParser; }

julianhille commented 10 months ago

why did you close it? from first perspective it looks like a but to be fixed.

mchepel commented 10 months ago

I closed it because there was no feedback for a week, I figured it is very low priority. After not getting this library working for what I needed it for, I just moved on. I will re-open the issue, maybe others will find it useful.

julianhille commented 10 months ago

May I ask what you needed what the lib could not do?

julianhille commented 10 months ago

The args are thrown against https://github.com/julianhille/MuhammaraJS/blob/76b978920c3fea4774f441a34525488a0ac187be/src/DocumentCopyingContextDriver.cpp#L270

which instanciates: https://github.com/julianhille/MuhammaraJS/blob/76b978920c3fea4774f441a34525488a0ac187be/src/ConstructorsHolder.cpp#L57 need to dig deeper

mchepel commented 10 months ago

May I ask what you needed what the lib could not do?

I needed to fill out a pdf file (find / replace text) but I just could not get it to work. Tried everything I could find online. No errors but no result either. I can share the code if you are interested.

julianhille commented 9 months ago

Please share the code.