julianhille / MuhammaraJS

Muhammara a node module with c/cpp bindings to modify PDF with js for node or electron (based/replacement on/of galkhana/hummusjs)
Other
205 stars 43 forks source link

No `package-lock.json` #336

Closed ericbf closed 8 months ago

ericbf commented 8 months ago

Not sure if this has been discussed somewhere, but it’s best practice to commit the package-lock.json to ensure stable and portable installs. Even npm gives the explicit message: npm notice created a lockfile as package-lock.json. You should commit this file.

Can we add the package-lock.json to the repository?