search

julianhille / MuhammaraJS

Muhammara a node module with c/cpp bindings to modify PDF with js for node or electron (based/replacement on/of galkhana/hummusjs)
Other
205 stars 41 forks source link

Use `Buffer.from` instead of `new Buffer` #339

Open ericbf opened 8 months ago

ericbf commented 8 months ago

The Buffer constructor is deprecated, so we should use the recommended Buffer.from instead.

Fixes #338

julianhille commented 8 months ago

this seems to trigger issues, needs further investigation

ericbf commented 8 months ago

this seems to trigger issues, needs further investigation

Hmmm. I didn’t even do any further testing for this one as I figured it was a drop-in replacement. Will look a little further.

julianhille commented 8 months ago

Might has To-Do with this: https://github.com/julianhille/MuhammaraJS/issues/258