search

julianhille / MuhammaraJS

Muhammara a node module with c/cpp bindings to modify PDF with js for node or electron (based/replacement on/of galkhana/hummusjs)
Other
205 stars 41 forks source link

Build musl/musl-arm with node 20 #358

Closed guillaumelecerf closed 7 months ago

julianhille commented 7 months ago

Thanks fornthe controbution. Mind adding a Changelogo entry?

guillaumelecerf commented 7 months ago

Here it is (hoping the changelog message, as the commit one, is clear enough). I was waiting for the CI to run to confirm that it was actually buildable, but it seems broken (missing docker secrets).

julianhille commented 7 months ago

Here it is (hoping the changelog message, as the commit one, is clear enough). I was waiting for the CI to run to confirm that it was actually buildable, but it seems broken (missing docker secrets).

Yes. Thisnis because These are my docker Hub credentiald which are Not available to Public runs. Let me try to fix it

guillaumelecerf commented 7 months ago

Thanks! Would you please mind publishing the musl/musl-arm 4.0.0 build artefacts?

julianhille commented 7 months ago

Thanks! Would you please mind publishing the musl/musl-arm 4.0.0 build artefacts?

i wont push any updates to a 4.0.0 version anymore there will be a 4.1.0 (soom[TM])

tommyk commented 7 months ago

Thanks! Would you please mind publishing the musl/musl-arm 4.0.0 build artefacts?

i wont push any updates to a 4.0.0 version anymore there will be a 4.1.0 (soom[TM])

how long are you thinking before releasing 4.1.0? i am currently having to wait excessive times for this to be built locally, and do special github action caching to try and avoid this build taking ~6 minutes.

julianhille commented 6 months ago

4.1.0 Has been released