search

julianhille / MuhammaraJS

Muhammara a node module with c/cpp bindings to modify PDF with js for node or electron (based/replacement on/of galkhana/hummusjs)
Other
205 stars 41 forks source link

Recipe.registerFont does not return the Recipe instance #364

Closed tommyk closed 7 months ago

tommyk commented 7 months ago

overview

while chaining methods against the Recipe object, the registerFont method does not return the Recipe instance leading to undefined errors.

you can see the method is not returning anything below https://github.com/julianhille/MuhammaraJS/blob/70088a5f8a0b4ef91ef31d3067111e0a0071f9d4/lib/recipe/font.js#L55

this was tested against latest 4.0.0 release.

fix

i haven't tested this yet, but i would assume just adding a return this to the method above would fix this issue.