search

julianhille / MuhammaraJS

Muhammara a node module with c/cpp bindings to modify PDF with js for node or electron (based/replacement on/of galkhana/hummusjs)
Other
205 stars 41 forks source link

Update appendPage pages arg type declaration to support page ranges #383

Closed josiahyeow closed 2 months ago

josiahyeow commented 2 months ago

According to the docs, page ranges can be provided to the appendPage method as shown the example.

e.g. 

pdfDoc.appendPage(longPDF, [
    [1, 3],
    [6, 20],
  ])

The current type declaration for pages only supports pages value to be [1, 3, 4] or simply 1. This PR updates this type declaration to support the ranges shown in the example.

josiahyeow commented 2 months ago

Fixed codestyle issues