search

julianhyde / sqlline

Shell for issuing SQL to relational databases via JDBC
BSD 3-Clause "New" or "Revised" License
618 stars 146 forks source link

[SQLLINE-436] User configuration file for sqlline #437

Closed richardantal closed 2 years ago

julianhyde commented 3 years ago

We will also need user doc. Can you start by adding a specification to #436 explaining how things work, e.g. which file supersedes the other, whether command-line or session settings override, etc.

The test could use a few comments. E.g. that the following line should do X because of property Y in the config file.

The test seems to use files outside of the git sandbox, and that might cause problems (e.g. mess in the users's home directory, failure if the home directory is not writeable, clashes if we run the tests from two sandboxes simultaneously). Any ideas how to fix those problems?

richardantal commented 3 years ago

Thank you @julianhyde for the review! Provided a short explanation of the expected behaviour. Changed the test to use a tmp file, and wrote some comments on it.

snuyanzin commented 2 years ago

LGTM @julianhyde if you do not have objections I can merge it somewhere in November

snuyanzin commented 2 years ago

merged at https://github.com/julianhyde/sqlline/commit/27bab8f87a6e12040e74c2619afcafde296f779a thanks @richardantal