julianhyde / sqlline

Shell for issuing SQL to relational databases via JDBC
BSD 3-Clause "New" or "Revised" License
618 stars 146 forks source link

[SQLLINE-440] Support legacy date/time format #442

Open richardantal opened 3 years ago

snuyanzin commented 2 years ago

Thanks for the PR @richardantal Sorry, I know it is a bit too late however in case you it is possible it would be great if you also add some tests

richardantal commented 2 years ago

Hi @snuyanzin I've done manual testing with Phoenix, I used the sqlline with my patch and tested it there. How do you suggest testing this further in an unittest?

stoty commented 8 months ago

I have opened https://github.com/julianhyde/sqlline/pull/478 for the same issue. That patch is smaller, and copies a solution already used in sqlline for numbers.