search

julianhyde / sqlline

Shell for issuing SQL to relational databases via JDBC
BSD 3-Clause "New" or "Revised" License
618 stars 146 forks source link

[SQLLINE-462] SQLLine should not fail in case of wrong input args #463

Closed snuyanzin closed 2 years ago

snuyanzin commented 2 years ago

The PR add check for the case of wrong args fixes #462

julianhyde commented 2 years ago

In my opinion, a better commit message would be the bug description "StringIndexOutOfBoundsException for wrong input arguments". It's more concrete, and more likely to match what a user is seeing.

Can you add a test for "--bad-argument" and make sure that there is a good error?

julianhyde commented 2 years ago

Oh, and the tool is called SQLLine not SqlLine. (I don't like the capitalization but we need to be consistent.)

julianhyde commented 2 years ago

+1 when you've added the test.

snuyanzin commented 2 years ago

Thanks, I've changed commit message. Yes, I've double checked https://github.com/julianhyde/sqlline/blob/main/HOWTO.md#branding You're right camel case is used only for class names

snuyanzin commented 2 years ago

merged as https://github.com/julianhyde/sqlline/commit/bf37172efc0725c5c8c08e6135506f860b2feab5