search

julianlam / nodebb-plugin-canned-responses

Allows users to save responses for use in the future
MIT License
6 stars 7 forks source link

Modal broken 1.1.2 #9

Closed exomarty closed 7 years ago

exomarty commented 8 years ago

It doesnt seems to open modal on the composer Nodebb 1.1.2

exomarty commented 8 years ago

I mean on 1.2.1

julianlam commented 8 years ago

I am unable to reproduce, modal opens fine on master and v1.2.1 of NodeBB.

exomarty commented 8 years ago

i get this error

exomarty commented 8 years ago

this is the error on the browser captura de pantalla 2016-10-29 a las 20 51 22

julianlam commented 8 years ago

Plugin version?

exomarty commented 8 years ago

Last one. Just reinstalles it again from package manager

julianlam commented 8 years ago

Need version # of canned responses plugin to ensure it actually affects latest... as you know, no repro means no fix, unfortunately.

exomarty commented 8 years ago

1.1.3 is the one i have installed

exomarty commented 8 years ago

just installed clean nodebb branch 1.x.x -> 1.2.1 up to date theme persona and no other plugins

Canned responses Installed 1.1.3 | Latest 1.1.3 Node js 4.0 redis db browser chrome on windows

I get this error while clicking on canned composer button

10/11 14:24 [25152] - info: NodeBB is now listening on: 0.0.0.0:4567 10/11 14:25 [25152] - error: /canned-responses TypeError: Cannot read property 'length' of undefined at sortedSetUnion (/volume1/web/nodebb/src/database/redis/sorted.js:272:46) at Object.module.getSortedSetUnion (/volume1/web/nodebb/src/database/redis/sorted.js:254:3) at Object.responses.list (/volume1/web/nodebb/node_modules/nodebb-plugin-canned-responses/lib/responses.js:18:12) at Controllers.getAll (/volume1/web/nodebb/node_modules/nodebb-plugin-canned-responses/lib/controllers.js:55:12) at Layer.handle as handle_request at next (/volume1/web/nodebb/node_modules/express/lib/router/route.js:131:13) at Route.dispatch (/volume1/web/nodebb/node_modules/express/lib/router/route.js:112:3) at Layer.handle as handle_request at /volume1/web/nodebb/node_modules/express/lib/router/index.js:277:22 at Function.process_params (/volume1/web/nodebb/node_modules/express/lib/router/index.js:330:12) at next (/volume1/web/nodebb/node_modules/express/lib/router/index.js:271:10) at Function.handle (/volume1/web/nodebb/node_modules/express/lib/router/index.js:176:3) at router (/volume1/web/nodebb/node_modules/express/lib/router/index.js:46:12) at Layer.handle as handle_request at trim_prefix (/volume1/web/nodebb/node_modules/express/lib/router/index.js:312:13) at /volume1/web/nodebb/node_modules/express/lib/router/index.js:280:7

the error on the browser was

screenshot_1

julianlam commented 7 years ago

Use latest version on nbbpm. Should be updated now.