search

julianlam / nodebb-plugin-github-embed

Turns issue numbers (#1234) into dynamic entities in posts
MIT License
7 stars 8 forks source link

Upcoming API change #21

Closed henrikekblad closed 4 years ago

henrikekblad commented 4 years ago

Received the following from github:

Hello there!
On February 6th, 2020 at 21:37 (UTC) your application (MySensors Web) used its `client_id` and `client_secret` (with the User-Agent nodebb-plugin-github-embed) as part of a set of query parameters to access an endpoint through the GitHub API:
https://api.github.com/repositories/85987908/issues/73
Please use Basic Authentication instead as using OAuth credentials in query parameters has been deprecated.
Depending on your API usage, we'll be sending you this email reminder at most once every 3 days.
Just one URL that was accessed with a User-Agent combination will be listed in the email reminder, not all.
Visit https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters for more information.
Thanks,
The GitHub Team
julianlam commented 4 years ago

Mm... I was initially a little confused because it's unsafe to pass id and secret in a query string, but this is a server-side call, so that mitigates the risk somewhat. That said, should be an easy fix I hope :thinking:

julianlam commented 4 years ago

v0.7.5

julianlam commented 4 years ago

@henrikekblad Let me know if this new version resolves the warning... like you I am also getting emailed every 3 days from GitHub :laughing:

henrikekblad commented 4 years ago

Haha, yeah. I think so. The guy in our team that received them have stopped complaining. :) Thanks!