search

julianlam / nodebb-plugin-google-analytics

Google Analytics Plugin for NodeBB
8 stars 8 forks source link

`action:ajaxifying` is triggered on the window now, instead of body #6

Closed akhoury closed 10 years ago

akhoury commented 10 years ago

according to this:

https://github.com/designcreateplay/NodeBB/blob/d61a75a5c2f7cc52f5e49cb86373ecb64bde84f3/NOTES.md#immediate-deprecation-notices

however, I can't find this action:ajaxifying anywhere in the code base anymore, it looks it has been replaced by action:ajaxify.start and action:ajaxify.end

am I right?

akhoury commented 10 years ago

but I can't even get this to work either :/ 

// paste in dev console, nothing happens when I navigate
// i got too lazy to debug but wanted to see if that's the right event
$('window').on('action:ajaxify.end', function(e){ console.log(e.type); });
psychobunny commented 10 years ago

@akhoury 

$(window).on('action:ajaxify.end', function(e){ console.log(e.type); });

sorry I'm sleepy, above is corrected version zzzzz :+1:

akhoury commented 10 years ago

/facepalm

akhoury commented 10 years ago

there should be jail time for abusing find/replace, along with copy/paste. Thanks @psychobunny

but this still yet to be corrected for this plugin

julianlam commented 10 years ago

What's going on, I swore I fixed this.

Edit: @akhoury The plugin works, last committed 14 days ago. The file you linked, I don't believe the plugin uses anymore, and can be safely deleted. Check lib/client.js

akhoury commented 10 years ago

ah! sorry, i didn't test, i just lurked around your source. Thanks