julianlam / nodebb-plugin-google-analytics

Google Analytics Plugin for NodeBB
8 stars 8 forks source link

Warning #7

Closed henrikekblad closed 10 years ago

henrikekblad commented 10 years ago

Pulled the latest today. Just wonder if it is normal to get a:

warn: Route requested but not found: /api/plugins/google-analytics

In the nodebb log?

Thanks Henrik

julianlam commented 10 years ago

Sounds like a bug in core that was fixed yesterday... Are you sure you're running the latest core code?

henrikekblad commented 10 years ago

Did a git pull an hour ago.

julianlam commented 10 years ago

When that happened yesterday, I noticed that the ACP no longer worked when clicking links, but did when I loaded the page from the address bar (or via refresh).

What version is your nodebb-widget-essentials package at?

henrikekblad commented 10 years ago

"name": "nodebb-widget-essentials", "version": "0.0.21-22",

julianlam commented 10 years ago

Thanks, looks like you're up to date. I honestly have no idea why this is happening, and why it magically stopped today. When you updated NodeBB, did you also run ./nodebb upgrade?

henrikekblad commented 10 years ago

No. But I have tried it now with no change.

The warning comes for every full page load (ajax-switching page does not trigger it).

julianlam commented 10 years ago

Does the admin page still work? Is the error just for this plugin?

henrikekblad commented 10 years ago

Yes the analytics-admin page work. The warning comes when loading forum page. All other plugins seems to work as normal (admin pages also).

(I just had to switch to use your fork of the local-email-plugin)

julianlam commented 10 years ago

Just installed the plugin locally and added UA code. ACP working fine here.

My dependencies for themes/widgets, with nodebb git hash:

julian@snow ~/Projects/nodebb/forum (master) $ npm ls nodebb-theme-vanilla nodebb-theme-lavender nodebb-widget-essentials nodebb-plugin-google-analytics && git rev-parse HEAD
nodebb@0.4.3 /home/julian/Projects/nodebb/forum
├── nodebb-plugin-google-analytics@0.3.2  -> /home/julian/Projects/nodebb/plugins/google-analytics extraneous
├── nodebb-theme-lavender@0.0.64 
├── nodebb-theme-vanilla@0.0.85  -> /home/julian/Projects/nodebb/themes/vanilla
└── nodebb-widget-essentials@0.0.21-22 

(the -> means it's a linked dep, but that shouldn't make any difference)

julianlam commented 10 years ago

Oh, you were loading the forum page! Okay, reproduced. :smile:

henrikekblad commented 10 years ago

Puh.. good start. :)

henrikekblad commented 10 years ago

When I look at google analytics page nothing is reported anymore. So the warning seems valid. Time for bed here in Sweden. Let me know if you need more assistance.

Regards Henrik

julianlam commented 10 years ago

@henrikekblad I've got it now. Fix should be committed and pushed within half an hour. Good night :smile:

julianlam commented 10 years ago

v0.3.3 published to npm. Thanks for your help!

henrikekblad commented 10 years ago

A patch ready 3 hours after report. This is great. Thank you!