julianlam / nodebb-plugin-gravatar

Exposes Gravatars to NodeBB users
MIT License
7 stars 9 forks source link

Refactoring custom default avatar provider handling #12

Closed king-cat closed 7 years ago

king-cat commented 7 years ago

The original way forced use of the default image (when a custom provider was set) and ignored the gravatar return value for some reason. This refactor will handle both custom providers and the built-in default providers in an expected way: If the user has a valid gravatar, it's used, if not, a default image from the selected provider will be used.

julianlam commented 7 years ago

LGTM :smile: