New cookie changes option: Update

julianlam / nodebb-plugin-session-sharing

Allows login sessions from your app to persist in NodeBB

MIT License

88 stars 65 forks source link

New cookie changes option: Update #101

Closed nesro closed 3 years ago

nesro commented 3 years ago

Hi, we need a functionality that is something between Trust and Revalidate cookie options:

Users are not logged out when the session sharing cookie is missing (Trust)
User profile is updated when the session sharing cookie contains new information (Revalidate)

I created new cookie option called 'Update' that does both things. The name, or the settings description might be a subject to change of course.

Thanks Tomas

julianlam commented 3 years ago

How about trust, verify, and paranoid :laughing:

julianlam commented 3 years ago

Anyway, update is fine by me, I'm looking at the changeset and not seeing exactly how it works with so few changed lines, but the logic is rather opaque, so I'll need to look at it more closely.

julianlam commented 3 years ago

Looks good to me -- v4.8.0 :+1:

nesro commented 3 years ago

Thanks Julian!

nesro commented 3 years ago

Hi @julianlam , would it be possible to release version v4.8.0 with those changes please?

julianlam commented 3 years ago

Hi @nesro, sorry about that. v5.0.0 should contain those changes.

nesro commented 3 years ago

No problem. We already use 5.0.0. Thanks 😊