julianlam / nodebb-plugin-session-sharing

Allows login sessions from your app to persist in NodeBB
MIT License
88 stars 65 forks source link

Socket admin.user.search doesnt exist in 1.17.1 #103

Closed uplift closed 2 years ago

uplift commented 3 years ago

In Nodebb 1.17.1 the socket admin.user.search is no longer implemented so searching by usernames in session sharing admin field fails.

https://github.com/julianlam/nodebb-plugin-session-sharing/blob/bf94e60d23c41f48c77980ced441d195e0b43824/static/lib/admin.js#L38

In an upcoming PR I've replaced the socket call with xhr call to /api/admin/manage/users? which seems to work (coied from users admin page search. Is their another option to make this call which would be better?