search

julianlam / nodebb-plugin-session-sharing

Allows login sessions from your app to persist in NodeBB
MIT License
86 stars 66 forks source link

Fixes for 103, 104, 105 #106

Closed uplift closed 2 years ago

uplift commented 2 years ago

I'll preface this by saying I've tested locally but it hasn't gone through my internal test team and wont for a few weeks. Its up to you whether you want to accept now or not. I cant find any issues with it. (Classic Dev speak 😄)

Also it hasn't been tested with jsonwebtoken library as we don't use it but I checked the API for it and it can be used sync with async await so should work fine.

Let me know if you require any changes to code or wording for the new option.

https://github.com/julianlam/nodebb-plugin-session-sharing/issues/103 https://github.com/julianlam/nodebb-plugin-session-sharing/issues/104 https://github.com/julianlam/nodebb-plugin-session-sharing/issues/105

julianlam commented 2 years ago

The changeset is large, but the portions I went through seem ok. Will do a cursory usage test and merge if passing. Appreciate this, it's always nicer to work with async..await code.

julianlam commented 2 years ago

I've rebased the last two commits into the one before, and rebased the branch onto master. v5.0.0