search

julianlam / nodebb-plugin-session-sharing

Allows login sessions from your app to persist in NodeBB
MIT License
88 stars 65 forks source link

Fix for #109 #110

Closed uplift closed 3 years ago

uplift commented 3 years ago
julianlam commented 3 years ago

LGTM but will need to step through the flow a couple times to ensure it works.

This is where tests would've come in handy 🤦 😮‍💨

julianlam commented 3 years ago

85d5a9cd6c69323bece60a2afb5973de694fe80f :smile:

julianlam commented 3 years ago

Tests continue to pass (although there's no accounting for the scenario where I didn't write the right tests, I guess!) LGTM!

uplift commented 2 years ago

For what its worth I ran it locally for month without any issues though not as good as having tests 😃